[jira] [Commented] (JAMES-1605) AbstractRecipientRewriteTable.mapAddress doesn't respect domainAlias ordering

["ASF GitHub Bot (JIRA)" <se...@james.apache.org>]

    [ https://issues.apache.org/jira/browse/JAMES-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718304#comment-14718304 ] 

ASF GitHub Bot commented on JAMES-1605:
---------------------------------------

GitHub user mbaechler opened a pull request:

    https://github.com/apache/james/pull/3

    JAMES-1605 fix AbstractRecipientRewriteTable.mapAddress to respect or…

    …dering

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbaechler/james JAMES-1605

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/james/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit 6aa2d52c6c9a90b56f4dcab1eb95030d7aa6a30b
Author: Matthieu Baechler <ma...@gmail.com>
Date:   2015-08-28T10:01:14Z

    JAMES-1605 fix AbstractRecipientRewriteTable.mapAddress to respect ordering

----


> AbstractRecipientRewriteTable.mapAddress doesn't respect domainAlias ordering
> -----------------------------------------------------------------------------
>
>                 Key: JAMES-1605
>                 URL: https://issues.apache.org/jira/browse/JAMES-1605
>             Project: James Server
>          Issue Type: Bug
>            Reporter: Matthieu Baechler
>
> This code snippet seems to tries to putting aliasdomain entries in front of the list while keeping entries original order.
>  
> {code}
>  while (mapIt.hasNext()) {
>                 int i = 0;
>                 String mapping = mapIt.next();
>                 if (mapping.startsWith(RecipientRewriteTable.ALIASDOMAIN_PREFIX)) {
>                     col.add(i, mapping);
>                     i++;
>                 } else {
>                     col.add(mapping);
>                 }
>             }
> {code}
> I looks like no test covers this feature because it actually mess with aliasdomain ordering (the 'i' counter is reset for every loop)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org