[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

[Ethanlm <gi...@git.apache.org>]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2698#discussion_r192433936
  
    --- Diff: DEVELOPER.md ---
    @@ -239,8 +239,13 @@ To pull in a merge request you should generally follow the command line instruct
     # Build the code and run the tests
     
     ## Prerequisites
    -First of all you need to make sure you are using maven 3.2.5 or below.  There is a bug in later versions of maven as linked to from https://issues.apache.org/jira/browse/MSHADE-206 that
    -cause shaded dependencies to not be packaged correctly.  Also please be aware that because we are shading dependencies mvn dependency:tree will not always show the dependencies correctly. 
    +To work around a conflict between the shade plugin and maven https://issues.apache.org/jira/browse/MSHADE-206 the build is spit into 2 parts.
    +First a set of dependencies are shaded and installed by running.
    +
    +```sh
    +cd shaded-deps
    +mvn clean install
    +```
    --- End diff --
    
    A little reordering of the sentences:
    
    To work around a conflict between the shade plugin and maven https://issues.apache.org/jira/browse/MSHADE-206, a set of dependencies needs to be shaded and installed by running:
    
    ```sh
    cd shaded-deps
    mvn clean install
    ```


---