You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bf...@apache.org on 2014/05/05 21:17:00 UTC

git commit: updated refs/heads/4.4-forward to 259ce3b

Repository: cloudstack
Updated Branches:
  refs/heads/4.4-forward 2c4ae0883 -> 259ce3b59


CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL

Signed-off-by: Brian Federle <br...@citrix.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/259ce3b5
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/259ce3b5
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/259ce3b5

Branch: refs/heads/4.4-forward
Commit: 259ce3b59c6a8633fc77a7eac88fbefd915107e2
Parents: 2c4ae08
Author: Dariusz Nejbauer <d....@samsung.com>
Authored: Mon May 5 12:14:34 2014 -0700
Committer: Brian Federle <br...@citrix.com>
Committed: Mon May 5 12:16:54 2014 -0700

----------------------------------------------------------------------
 ui/scripts/ui/widgets/detailView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/259ce3b5/ui/scripts/ui/widgets/detailView.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/detailView.js b/ui/scripts/ui/widgets/detailView.js
index e083878..c6cf1ca 100644
--- a/ui/scripts/ui/widgets/detailView.js
+++ b/ui/scripts/ui/widgets/detailView.js
@@ -954,7 +954,7 @@
                     return true;
                 }
 
-                var $detail = $('<tr></tr>').addClass(key).appendTo($detailTable);
+                var $detail = $('<tr></tr>').addClass(key + '-row').appendTo($detailTable);
                 var $name = $('<td></td>').addClass('name').appendTo($detail);
                 var $value = $('<span>').appendTo($('<td></td>').addClass('value').appendTo($detail));
                 var content = data[key];


Re: git commit: updated refs/heads/4.4-forward to 259ce3b

Posted by Daan Hoogland <da...@gmail.com>.
On Mon, May 5, 2014 at 10:44 PM, Brian Federle <Br...@citrix.com> wrote:
> Please cp 38c99ffdab61ecbadf156f266ba4535958dcb67f first, then 44a3f586d87fa7b4793cc753509024847270444f


both in

-- 
Daan

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

Posted by Brian Federle <Br...@citrix.com>.
Daan, oops, I think the problem is  I forgot to include a commit in the original cherry-pick request.

Please cp 38c99ffdab61ecbadf156f266ba4535958dcb67f first, then 44a3f586d87fa7b4793cc753509024847270444f

Thanks,
Brian

-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com] 
Sent: Monday, May 05, 2014 1:28 PM
To: Brian Federle
Cc: dev
Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b

On Mon, May 5, 2014 at 9:36 PM, Brian Federle <Br...@citrix.com> wrote:
> 4d84970ddc91c2269807708e722942e9bc758185


doesn't apply/cherry-pick

-- 
Daan

Re: git commit: updated refs/heads/4.4-forward to 259ce3b

Posted by Daan Hoogland <da...@gmail.com>.
On Mon, May 5, 2014 at 9:36 PM, Brian Federle <Br...@citrix.com> wrote:
> 4d84970ddc91c2269807708e722942e9bc758185


doesn't apply/cherry-pick

-- 
Daan

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

Posted by Brian Federle <Br...@citrix.com>.
It's a minor but easy fix, so it wouldn't hurt :)

Also, can you please cherry pick in 4d84970ddc91c2269807708e722942e9bc758185? This is a fix for a Firefox incompatibility for CLOUDSTACK-6342, where Firefox wasn't rendering the changes correctly (I was just going to make a separate request for that).

Thanks Daan.

-Brian

-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com] 
Sent: Monday, May 05, 2014 12:23 PM
To: dev; Brian Federle
Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b

On Mon, May 5, 2014 at 9:17 PM,  <bf...@apache.org> wrote:
> 259ce3b59c6a8633fc77a7eac88fbefd915107e2


so I guessed you'd want it cherry-picked ;)

-- 
Daan

Re: git commit: updated refs/heads/4.4-forward to 259ce3b

Posted by Daan Hoogland <da...@gmail.com>.
On Mon, May 5, 2014 at 9:17 PM,  <bf...@apache.org> wrote:
> 259ce3b59c6a8633fc77a7eac88fbefd915107e2


so I guessed you'd want it cherry-picked ;)

-- 
Daan