You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Thorsten von Eicken (JIRA)" <ji...@apache.org> on 2009/06/04 17:35:07 UTC
[jira] Created: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Incorrect parameter names in Thrift interface
---------------------------------------------
Key: CASSANDRA-214
URL: https://issues.apache.org/jira/browse/CASSANDRA-214
Project: Cassandra
Issue Type: Bug
Reporter: Thorsten von Eicken
Priority: Minor
The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716672#action_12716672 ]
Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------
can't you do a _since on a supercolumn? the subcolumns are sorted by time.
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716355#action_12716355 ]
Jun Rao commented on CASSANDRA-214:
-----------------------------------
How about columnFamily__OR__columnFamily_superColumn ?
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-214:
-------------------------------------
Affects Version/s: 0.3
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-214:
----------------------------------------
Assignee: Jonathan Ellis
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716736#action_12716736 ]
Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------
You're right, should be columnParent.
Committed w/ that change.
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716687#action_12716687 ]
Jun Rao commented on CASSANDRA-214:
-----------------------------------
It seems get_slice_since can be used on a SCF. So the parameter should be columnParent instead.
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716666#action_12716666 ]
Jun Rao commented on CASSANDRA-214:
-----------------------------------
Looks fine to me in general. For get_columns_since, 3:string columnPath should be columnFamily.
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716360#action_12716360 ]
Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------
better, but a little unwieldy :)
columnParent? columnOwner? columnContainer?
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-214:
-------------------------------------
Attachment: 214.patch
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-214:
-------------------------------------
Component/s: Core
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Thorsten von Eicken (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716403#action_12716403 ]
Thorsten von Eicken commented on CASSANDRA-214:
-----------------------------------------------
Maybe instead of focusing on the name it would be good to first focus on the actual spec? I.e. in which operations can which forms of column / super column spec be used? IMHO it would be more important to add this in the form of comments in the interface spec than trying to come up with names that capture all this in_one_word...
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716337#action_12716337 ]
Jun Rao commented on CASSANDRA-214:
-----------------------------------
The patch looks fine.
Now that we are on Thrift api.
3:string columnFamily_column in get_slice is also confusing. In a regular CF, the parameter should be just CF. In a super CF, the parameter could also be CF_superColumn. Neither matches the current parameter name. Since most users are likely on regular CF, may be we should rename 3 to just columnFamily?
Similarly, I propose changing 3:string columnFamily_column in get_column_count to just columnFamily.
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716408#action_12716408 ]
Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------
we ought to be able to do better than that in the code w/ overloaded methods that each have a real signature where a string is a string not two connected with a colon :)
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-214:
-------------------------------------
Attachment: 214-v2.patch
Okay, second stab here at the interface file. I'll update CassandraServer if these are reasonable.
for convenience, here is the terminology used in the patch:
# CF = ColumnFamily name
# SC = SuperColumn name
# C = Column name
# columnParent: the parent of the columns you are specifying. "CF" or "CF:SC".
# columnPath: full path to a column. "CF:C" or "CF:SC:C".
# superColumnPath: full path to a supercolumn. "CF:SC" only.
# columnPathOrParent: remove will wipe out any layer. "CF" or "CF:C" or "CF:SC" or "CF:SC:C".
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214-v2.patch, 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716347#action_12716347 ]
Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------
i don't know that being wrong X% of the time is that much better than 100 - X% :)
what if we name it something more generic? `columnFamily_params`, or `column_path`?
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-214) Incorrect parameter names in Thrift
interface
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-214:
-------------------------------------
Fix Version/s: 0.3
Affects Version/s: (was: 0.3)
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-214) Incorrect parameter names in
Thrift interface
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716405#action_12716405 ]
Sandeep Tata commented on CASSANDRA-214:
----------------------------------------
There are a bunch of places in the code that have the same problem -- it is not clear if a variable should contain "CF:col" or "CF" ... we should slowly clean that up using whatever naming convention we pick here. (In addition to writing better comments.)
> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
> Key: CASSANDRA-214
> URL: https://issues.apache.org/jira/browse/CASSANDRA-214
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Thorsten von Eicken
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string columnFamily_superColumnName" should really be "3:string columnFamily"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.