You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/04/01 02:50:13 UTC

[GitHub] [zeppelin] xiejiajun opened a new pull request #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

xiejiajun opened a new pull request #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710
 
 
   ### What is this PR for?
   - an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete when i try remove a paragraph.
   
   
   ### What type of PR is it?
   - Bug Fix
   
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4712
   
   ### Questions:
   Does the licenses files need update? NO
   Is there breaking changes for older versions? NO
   Does this needs documentation? NO
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710#issuecomment-608264849
 
 
   I think we should add throw Exception for method `removeResourcesBelongsToParagraph` and let the caller decide how to handle the exception. What do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710#issuecomment-610296055
 
 
   Sorry for late response, @xiejiajun  Your explanation make sense to me.  I think we need to improve the exception handling where we don't have very well convention. Currently your PR LGTM for fixing this issue 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] asfgit closed pull request #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] xiejiajun commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

Posted by GitBox <gi...@apache.org>.
xiejiajun commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710#issuecomment-608348815
 
 
   > I think we should add throw Exception for method `removeResourcesBelongsToParagraph` and let the caller decide how to handle the exception. What do you think ?
   
   @zjffdu , i have considered this. If we do this, removeNote, removeFolder, and removeParagraph will need to handle this exception separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] xiejiajun commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused

Posted by GitBox <gi...@apache.org>.
xiejiajun commented on issue #3710: [ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused
URL: https://github.com/apache/zeppelin/pull/3710#issuecomment-608385353
 
 
   > I think we should add throw Exception for method `removeResourcesBelongsToParagraph` and let the caller decide how to handle the exception. What do you think ?
   
   another purpose of  caught this exception in the removeResourcesBelongsToParagraph method is  in order to make  other running interpreters can  release resources that related to the paragraph that  needs to be removed. @zjffdu 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services