[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2600: Dev 1.2.0 fix

[GitBox <gi...@apache.org>]

casionone commented on code in PR #2600:
URL: https://github.com/apache/incubator-linkis/pull/2600#discussion_r938374261


##########
linkis-computation-governance/linkis-manager/linkis-label-common/src/main/java/org/apache/linkis/manager/label/entity/engine/EngineType.scala:
##########
@@ -92,6 +92,9 @@ object EngineType extends Enumeration with Logging {
     case _ if APPCONN.toString.equals(str) => APPCONN

Review Comment:
   I don't think the scalability is so good in this way. 
   try to use Enumeration.withName replace it 
   
   https://stackoverflow.com/questions/33593525/scala-safe-way-of-converting-string-to-enumeration-value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org