[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #256: add CORS specific notice to pekko-http-cors jar

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256#discussion_r1269081318


##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -41,6 +41,13 @@ object AddMetaInfLicenseFiles extends AutoPlugin {
     apacheSonatypeLicenseFile := baseDir.value / "LICENSE",
     apacheSonatypeNoticeFile := baseDir.value / "NOTICE")
 
+  /**
+   * Settings specific for Pekko http-cors subproject which require a different license file.
+   */
+  lazy val httpCorsSettings = Seq(
+    apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
+    apacheSonatypeNoticeFile := baseDir.value / "legal" / "CorsNotice.txt")

Review Comment:
   this is inherited from the projectSetting - that adds the DISCLAIMER to all jars - it is the same DISCLAIMER in all jars but the LICENSE and NOTICE can be specific to a jar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org