You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "anuragp010 (via GitHub)" <gi...@apache.org> on 2026/09/28 10:01:27 UTC
[PR] HDDS-16586. Add support for displaying storage type of replicas in container info command. [ozone]
anuragp010 opened a new pull request, #11347:
URL: https://github.com/apache/ozone/pull/11347
Co-authored-by: XiChen <32...@users.noreply.github.com>
## What changes were proposed in this pull request?
`ozone admin container info <cid>` lists all replicas of a container. With the Storage Policy feature, a container is stamped with a `StorageType` when it is created, and each of its replicas is placed on a datanode volume that carries its own labelled `StorageType`.
The command currently shows neither value, so there is no way to tell which tier a replica actually occupies. This PR reports the container's `StorageType`, the `StorageType` of the volume holding the replica, and the replica's on-disk container path, passed from the datanode through SCM in the container reports to the CLI.
ContainerPath is printed with each replica; the two `StorageTypes` are shown when `--with-storagetype` is passed. `--json` always includes all three fields.
## What is the link to the Apache JIRA
[HDDS-16586](https://issues.apache.org/jira/browse/HDDS-16586)
## How was this patch tested?
1. Newly added Unit Tests and Integration Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16586. Add support for displaying storage type of replicas in container info command. [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu merged PR #11347:
URL: https://github.com/apache/ozone/pull/11347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16586. Add support for displaying storage type of replicas in container info command. [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #11347:
URL: https://github.com/apache/ozone/pull/11347#discussion_r4121394044
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java:
##########
@@ -284,10 +285,15 @@ ContainerReplicaProto buildContainerReplicaProto() throws StorageContainerExcept
.setReplicaIndex(getReplicaIndex())
.setBlockCommitSequenceId(getBlockCommitSequenceId())
.setDeleteTransactionId(getDeleteTransactionId())
- .setDataChecksum(getDataChecksum());
+ .setDataChecksum(getDataChecksum())
+ .setContainerPath(getContainerPath());
Review Comment:
Thanks @anuragp010 , as discussed, containerPath may not be needed in report as this will bloat the report size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16586. Add support for displaying storage type of replicas in container info command. [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #11347:
URL: https://github.com/apache/ozone/pull/11347#discussion_r4121403882
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java:
##########
@@ -284,10 +285,15 @@ ContainerReplicaProto buildContainerReplicaProto() throws StorageContainerExcept
.setReplicaIndex(getReplicaIndex())
.setBlockCommitSequenceId(getBlockCommitSequenceId())
.setDeleteTransactionId(getDeleteTransactionId())
- .setDataChecksum(getDataChecksum());
+ .setDataChecksum(getDataChecksum())
+ .setContainerPath(getContainerPath());
Review Comment:
@xichen01 , Kindly have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org