You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/22 11:15:51 UTC
[GitHub] [couchdb-documentation] willholley opened a new pull request #482:
Document enable_database_recovery
willholley opened a new pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
Adds documentation for couchdb.enable_database_recovery.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## GitHub issue number
Fixes #284
## Related Pull Requests
Description lifted from https://github.com/apache/couchdb/pull/1283
## Checklist
- [ ] Documentation is written and is accurate;
- [ ] `make check` passes with no errors
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the commit hash once this PR is rebased and merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] willholley commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
willholley commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369594734
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
> What happens in the case of deleting multiple databases with the same name? i.e. create "foo", soft-delete "foo", re-create "foo", soft-delete "foo".
good question and I don't know - I just copied the description from default.ini
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] willholley commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
willholley commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369559350
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
@jiangphcn just to clarify does `enable_database_recovery` toggles index soft deletion as well or are they configured independently? Do views follow the same behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] jiangphcn commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
jiangphcn commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369610059
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
there will be timestamp to distinguish them with the same database name, such as `foo.20170912.092828.deleted.1234567890`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] flimzy commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
flimzy commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369570064
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
What happens in the case of deleting multiple databases with the same name? i.e. create "foo", soft-delete "foo", re-create "foo", soft-delete "foo".
Is the original "foo" lost, or are these disambiguated in some way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] jiangphcn commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
jiangphcn commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369547231
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
The same for full text index, i.e. index generated by dreyfys/clouseau. The directory containing full text index will be renamed from `foo.1234567890` to `foo.20170912.092828.deleted.1234567890` for recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] willholley commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
willholley commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369594734
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
> What happens in the case of deleting multiple databases with the same name? i.e. create "foo", soft-delete "foo", re-create "foo", soft-delete "foo".
good question and I don't know - I just copied the description from default.ini
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] jiangphcn commented on a change in pull
request #482: Document enable_database_recovery
Posted by GitBox <gi...@apache.org>.
jiangphcn commented on a change in pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482#discussion_r369586456
##########
File path: src/config/couchdb.rst
##########
@@ -194,3 +194,16 @@ Base CouchDB Options
parameter was defined: :config:option:`httpd/max_http_request_size`,
which can be used to limit maximum http request sizes. After upgrade,
it is advisable to review those settings and adjust them accordingly.
+
+ .. config:option:: enable_database_recovery :: Enable database recovery
+
+ Enable this to only "soft-delete" databases when
+ :ref:`DELETE /{db} <api/db>` DELETE requests are made. This will place
+ a ``.recovery`` directory in your data directory and move deleted
+ databases/shards there instead. You can then manually delete these
+ files later, as desired.
+
Review comment:
@willholley one setting for all, at least for full text index https://github.com/apache/couchdb/blob/0155bd884bd8c455cc4057811cf67035b04c427f/src/dreyfus/src/dreyfus_index_manager.erl#L122. Views follow the same behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] kocolosk merged pull request #482: Document
enable_database_recovery
Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #482: Document enable_database_recovery
URL: https://github.com/apache/couchdb-documentation/pull/482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services