You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2015/11/12 18:49:58 UTC

Review Request 40240: RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40240/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Repository: ranger


Description
-------

RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas according to the following:

The class type requires atleast one required attribute. It doesn’t have to be called qualifiedName. The reason hive_table uses name is because it extends DataSet type and DataSet type has name which is same as qualifiedName. All other hive types don’t extends DataSet.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java 7925b5c 

Diff: https://reviews.apache.org/r/40240/diff/


Testing
-------

Ran unit tests. Tested against an Atlas installation in test cluster.


Thanks,

Abhay Kulkarni


Re: Review Request 40240: RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40240/#review106302
-----------------------------------------------------------

Ship it!


Ship It!

- Madhan Neethiraj


On Nov. 12, 2015, 5:49 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40240/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 5:49 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas according to the following:
> 
> The class type requires atleast one required attribute. It doesn’t have to be called qualifiedName. The reason hive_table uses name is because it extends DataSet type and DataSet type has name which is same as qualifiedName. All other hive types don’t extends DataSet.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java 7925b5c 
> 
> Diff: https://reviews.apache.org/r/40240/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests. Tested against an Atlas installation in test cluster.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 40240: RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40240/
-----------------------------------------------------------

(Updated April 13, 2017, 3:53 p.m.)


Review request for ranger and Madhan Neethiraj.


Repository: ranger


Description
-------

RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas according to the following:

The class type requires atleast one required attribute. It doesn\u2019t have to be called qualifiedName. The reason hive_table uses name is because it extends DataSet type and DataSet type has name which is same as qualifiedName. All other hive types don\u2019t extends DataSet.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java 7925b5c 


Diff: https://reviews.apache.org/r/40240/diff/1/


Testing
-------

Ran unit tests. Tested against an Atlas installation in test cluster.


Thanks,

Abhay Kulkarni