You are viewing a plain text version of this content. The canonical link for it is here.

Posted to java-dev@axis.apache.org by "Donnie Hale (JIRA)" <ax...@ws.apache.org> on 2005/01/01 20:09:38 UTC

[jira] Created: (AXIS-1740) Dead and/or Incomplete Code in JavaProvider / SOAPService

Dead and/or Incomplete Code in JavaProvider / SOAPService
---------------------------------------------------------

Key: AXIS-1740
URL: http://issues.apache.org/jira/browse/AXIS-1740
Project: Axis
Type: Bug
Versions: 1.2RC2
Environment: Axis 1.2RC2. Observed while single-stepping through code in debugger.
Reporter: Donnie Hale
Priority: Minor

In JavaProvider.getServiceObject, there's a branch to handle the condition if the service scope is "Scope.FACTORY". In trying to find out what functionality that scope might support (I hadn't seen mention of it in any documentation), I noticed that this branch of code references the SOAPService.serviceObjects public member variable. Looking at the SOAPService code, I see that this variable is a Map and references a HashMap instance. However, I've searched the entire code base and found no place where anything is ever placed into that map. So the branch in JavaProvider looking for a key which comes from the MessageContext's properties (msgContext.getStrProp("objectID")) will never succeed.

I've searched the entire code base for the following: "serviceObjects", "objectID", and "Scope.FACTORY". I've not found anything that gives me a hint as to what is / was supposed to be happening here.

I'm wondering if this is dead code from eliminating previous functionality or incomplete code for implementing new functionality. I did search the bug list before posting this. If it's a duplicate, my apologies...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira

[jira] Commented: (AXIS-1740) Dead and/or Incomplete Code in JavaProvider / SOAPService

Posted by "Neil Katin (JIRA)" <ax...@ws.apache.org>.

     [ http://issues.apache.org/jira/browse/AXIS-1740?page=comments#action_61990 ]
     
Neil Katin commented on AXIS-1740:
----------------------------------

I noticed this checkin comment that describes who and why added the code; I was trying to find an example of how to use it and couldn't find any code that did...

2004-05-03 20:04 gdaniels
	

Some changes deriving from the WS-RF interop work.

* Make sure soapAction gets reset on each call

* Pick up type mappings in getDeserializerForClass()

* Fix bug - make sure the same logic is followed in the
  deploy writer and the stub writer with respect to
  which types to write mappings for.  Factor out logic
  into a Utils method

* Factory scope plumbing - use the SOAPService object
  to hold a Map of object IDs to service objects.  When
  we get a request for a factory scoped service, some
  URL manager (SimpleAxisWorker, say) is responsible for
  parsing the URL and setting an "objectID" property in
  the MessageContext.  This gets used by the JavaProvider
  to locate the right object in the Map.  Custom factory
  methods can create new objects and drop them into
  the SOAPService's map directly.  Will clean up the APIs
  a bit here.

* Make sure null response messages are ok for
  SimpleAxisWorker

* Give SOAPBodyElement a (QName, Object) constructor

    * src/org/apache/axis/transport/http/SimpleAxisWorker.java (1.40)
    * src/org/apache/axis/wsdl/toJava/JavaDeployWriter.java (1.82)
    * src/org/apache/axis/wsdl/toJava/JavaStubWriter.java (1.132)
    * src/org/apache/axis/wsdl/toJava/Utils.java (1.87)


> Dead and/or Incomplete Code in JavaProvider / SOAPService
> ---------------------------------------------------------
>
>          Key: AXIS-1740
>          URL: http://issues.apache.org/jira/browse/AXIS-1740
>      Project: Axis
>         Type: Bug
>     Versions: 1.2RC2
>  Environment: Axis 1.2RC2. Observed while single-stepping through code in debugger.
>     Reporter: Donnie Hale
>     Priority: Minor

>
> In JavaProvider.getServiceObject, there's a branch to handle the condition if the service scope is "Scope.FACTORY". In trying to find out what functionality that scope might support (I hadn't seen mention of it in any documentation), I noticed that this branch of code references the SOAPService.serviceObjects public member variable. Looking at the SOAPService code, I see that this variable is a Map and references a HashMap instance. However, I've searched the entire code base and found no place where anything is ever placed into that map. So the branch in JavaProvider looking for a key which comes from the MessageContext's properties (msgContext.getStrProp("objectID")) will never succeed.
> I've searched the entire code base for the following: "serviceObjects", "objectID", and "Scope.FACTORY". I've not found anything that gives me a hint as to what is / was supposed to be happening here.
> I'm wondering if this is dead code from eliminating previous functionality or incomplete code for implementing new functionality. I did search the bug list before posting this. If it's a duplicate, my apologies...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira