[GitHub] [airflow] cqzlxl commented on a change in pull request #20491: Refactor: Remove unnecessary database commit and exception stack printing

[GitBox <gi...@apache.org>]

cqzlxl commented on a change in pull request #20491:
URL: https://github.com/apache/airflow/pull/20491#discussion_r774997902



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -684,7 +684,7 @@ def _execute(self) -> None:
 
             settings.Session.remove()  # type: ignore
         except Exception:
-            self.log.exception("Exception when executing SchedulerJob._run_scheduler_loop")
+            self.log.error("Exception when executing SchedulerJob._run_scheduler_loop")

Review comment:
       The re-raising exception below will not be caught by any upper caller of _execute(), the exception-level logging here leads to duplicated exception stack printing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org