[GitHub] mrutkows commented on a change in pull request #607: WIP: JSON Output support

[GitBox <gi...@apache.org>]

mrutkows commented on a change in pull request #607: WIP: JSON Output support 
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607#discussion_r146361901
 
 

 ##########
 File path: parsers/manifest_parser_test.go
 ##########
 @@ -339,15 +324,15 @@ func TestParseManifestForMultiLineParams(t *testing.T) {
 
         // validate outputs
         // output payload is of type string and has a description
-        if payload, ok := action.Outputs["payload"]; ok {
-            p := payload.(map[interface{}]interface{})
-            expectedResult = "string"
-            actualResult = p["type"].(string)
-            assert.Equal(t, expectedResult, actualResult, "Expected " + expectedResult + " but got " + actualResult)
-            expectedResult = "parameter dump"
-            actualResult = p["description"].(string)
-            assert.Equal(t, expectedResult, actualResult, "Expected " + expectedResult + " but got " + actualResult)
-        }
+        //if payload, ok := action.Outputs["payload"]; ok {
 
 Review comment:
   @houshengbo  I was wondering if you would catch this (saw this just before I asked you to review) ... i had removed it because:
   1) Outputs are now truly of type Parameter (and original code would not work and for got about it).
   2) I believed we needed more dedicated/comprehensive output tests for single, multi and JSON parameter types and had thought to open a new issue to address (which I just did):
   
   Will put back the previous payload assertion for now...
   
   and also opened this issue: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/620

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services