Re: [PR] HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms. [hbase]

["GeorryHuang (via GitHub)" <gi...@apache.org>]

GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1345039935


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java:
##########
@@ -584,4 +589,100 @@ public void run() {
     t2.join();
     assertFalse("Expected ConcurrentTableModificationException.", (t1.exception || t2.exception));
   }
+
+  @Test
+  public void testModifyWillNotReopenRegions() throws IOException {
+    final boolean reopenRegions = false;
+    final TableName tableName = TableName.valueOf(name.getMethodName());
+    final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();
+
+    MasterProcedureTestingUtility.createTable(procExec, tableName, null, "cf");
+    UTIL.getAdmin().disableTable(tableName);

Review Comment:
   This was an oversight. I will remove this code in the next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org