You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/05/05 20:03:57 UTC

Review Request 59029: Added a script to publish JARs to maven snapshot repository.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59029/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Kapil Arya.


Repository: mesos


Description
-------

This could be used to publish JARs from nightly builds. Most of the
code is copied from support/tag.sh.


Diffs
-----

  support/snapshot.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/59029/diff/1/


Testing
-------

Manually uploaded a snapshot build to maven


Thanks,

Vinod Kone


Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59029/#review174120
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59029]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 5, 2017, 8:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59029/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 8:03 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This could be used to publish JARs from nightly builds. Most of the
> code is copied from support/tag.sh.
> 
> 
> Diffs
> -----
> 
>   support/snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59029/diff/1/
> 
> 
> Testing
> -------
> 
> Manually uploaded a snapshot build to maven
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59029/#review183153
-----------------------------------------------------------




support/snapshot.sh
Lines 60 (patched)
<https://reviews.apache.org/r/59029/#comment259179>

    Can we also provide the location of the maven snapshot directory?


- Kapil Arya


On May 5, 2017, 4:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59029/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 4:03 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This could be used to publish JARs from nightly builds. Most of the
> code is copied from support/tag.sh.
> 
> 
> Diffs
> -----
> 
>   support/snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59029/diff/1/
> 
> 
> Testing
> -------
> 
> Manually uploaded a snapshot build to maven
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59029/#review183160
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59029]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On May 5, 2017, 1:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59029/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 1:03 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This could be used to publish JARs from nightly builds. Most of the
> code is copied from support/tag.sh.
> 
> 
> Diffs
> -----
> 
>   support/snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59029/diff/1/
> 
> 
> Testing
> -------
> 
> Manually uploaded a snapshot build to maven
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59029/#review183154
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On May 5, 2017, 4:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59029/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 4:03 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This could be used to publish JARs from nightly builds. Most of the
> code is copied from support/tag.sh.
> 
> 
> Diffs
> -----
> 
>   support/snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59029/diff/1/
> 
> 
> Testing
> -------
> 
> Manually uploaded a snapshot build to maven
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>