You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2022/10/25 02:42:22 UTC
[orc] branch branch-1.8 updated: ORC-1295: Improve ORC Spec example (Decoding RLE v2 direct
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.8 by this push:
new db2bc7f21 ORC-1295: Improve ORC Spec example (Decoding RLE v2 direct
db2bc7f21 is described below
commit db2bc7f214a7eecfa545961d8c995c2b151ec713
Author: deshanxiao <de...@microsoft.com>
AuthorDate: Mon Oct 24 19:42:07 2022 -0700
ORC-1295: Improve ORC Spec example (Decoding RLE v2 direct
### What changes were proposed in this pull request?
Improve ORC Spec example (Decoding RLE v2 direct
### Why are the changes needed?
To solve https://github.com/apache/orc/issues/1184
### How was this patch tested?
Test in local docker env.
Closes #1184
Closes #1287 from deshanxiao/deshan/1295.
Authored-by: deshanxiao <de...@microsoft.com>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
(cherry picked from commit e5d162db7319b85cc6fb58de14635032ec3628b1)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
site/img/Direct.png | Bin 0 -> 64400 bytes
site/specification/ORCv1.md | 5 +++++
site/specification/ORCv2.md | 5 +++++
3 files changed, 10 insertions(+)
diff --git a/site/img/Direct.png b/site/img/Direct.png
new file mode 100644
index 000000000..eadf5ff87
Binary files /dev/null and b/site/img/Direct.png differ
diff --git a/site/specification/ORCv1.md b/site/specification/ORCv1.md
index 472e11e5b..a7f5ddfb7 100644
--- a/site/specification/ORCv1.md
+++ b/site/specification/ORCv1.md
@@ -793,6 +793,11 @@ serialized with direct encoding (1), a width of 16 bits (15), and
length of 4 (3) as [0x5e, 0x03, 0x5c, 0xa1, 0xab, 0x1e, 0xde, 0xad,
0xbe, 0xef].
+> Note: the run length(4) is one-off. We can get 4 by adding 1 to 3
+(See [Hive-4123](https://github.com/apache/hive/commit/69deabeaac020ba60b0f2156579f53e9fe46157a#diff-c00fea1863eaf0d6f047535e874274199020ffed3eb00deb897f513aa86f6b59R232-R236))
+
+![Direct](/img/Direct.png)
+
### Patched Base
The patched base encoding is used for integer sequences whose bit
diff --git a/site/specification/ORCv2.md b/site/specification/ORCv2.md
index 703cea01d..334896fa0 100644
--- a/site/specification/ORCv2.md
+++ b/site/specification/ORCv2.md
@@ -812,6 +812,11 @@ serialized with direct encoding (1), a width of 16 bits (15), and
length of 4 (3) as [0x5e, 0x03, 0x5c, 0xa1, 0xab, 0x1e, 0xde, 0xad,
0xbe, 0xef].
+> Note: the run length(4) is one-off. We can get 4 by adding 1 to 3
+(See [Hive-4123](https://github.com/apache/hive/commit/69deabeaac020ba60b0f2156579f53e9fe46157a#diff-c00fea1863eaf0d6f047535e874274199020ffed3eb00deb897f513aa86f6b59R232-R236))
+
+![Direct](/img/Direct.png)
+
### Patched Base
The patched base encoding is used for integer sequences whose bit