You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/14 20:19:34 UTC
Review Request 44802: GEODE-1049
LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44802/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
Added wait criteria for InternalDistributedSystem to initialize
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java 493c625
Diff: https://reviews.apache.org/r/44802/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 44802: GEODE-1049
LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44802/#review123526
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On March 14, 2016, 7:19 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44802/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:19 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added wait criteria for InternalDistributedSystem to initialize
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java 493c625
>
> Diff: https://reviews.apache.org/r/44802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 44802: GEODE-1049
LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44802/#review123546
-----------------------------------------------------------
Ship it!
Change looks good. Just one more comment: A brief description of the fix (even a sentence) in the code review or JIRA, will help understand the fix.
- Jianxia Chen
On March 14, 2016, 7:19 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44802/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:19 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added wait criteria for InternalDistributedSystem to initialize
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java 493c625
>
> Diff: https://reviews.apache.org/r/44802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 44802: GEODE-1049
LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44802/#review123525
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 14, 2016, 7:19 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44802/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:19 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added wait criteria for InternalDistributedSystem to initialize
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java 493c625
>
> Diff: https://reviews.apache.org/r/44802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>