You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/21 09:38:54 UTC

[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #58: Rename akka package to org.apache.pekko

jrudolph commented on code in PR #58:
URL: https://github.com/apache/incubator-pekko/pull/58#discussion_r1027777040


##########
akka-actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/CapturedLogEvent.scala:
##########
@@ -11,13 +11,14 @@ import scala.compat.java8.OptionConverters._
 import org.slf4j.Marker
 import org.slf4j.event.Level
 
-import akka.annotation.InternalApi
-import akka.util.OptionVal
+import org.apache.pekko
+import pekko.annotation.InternalApi

Review Comment:
   I'd say ultimately, we'd want fully-qualified imports because that's what everyone uses and also what IDEs usually create.
   
   Regarding, the usages in code directly, I agree with your approach, it doesn't make sense to use FQCN in that case.
   
   In any case, if you made significant changes and it works like this, cleaning up the imports can be done later, indeed. It will unfortunately lead to lots of conflicts so we should do it rather soon, though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org