[GitHub] [calcite] quxiucheng commented on a change in pull request #1568: [CALCITE-3486] In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it (quxiucheng)

[GitBox <gi...@apache.org>]

quxiucheng commented on a change in pull request #1568: [CALCITE-3486] In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it (quxiucheng)
URL: https://github.com/apache/calcite/pull/1568#discussion_r344489988
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java
 ##########
 @@ -179,6 +179,9 @@ public boolean supportsAliasedValues() {
 
       unparseFloor(writer, call);
       break;
+    case ROW:
+      unparseRow(writer, call);
 
 Review comment:
   done.
   but  the class `SqlDialect` can't get the method `SqlConformance#allowExplicitRowValueConstructor` correctly. I added a field in the class `SqlDialect`, Same as the field 'SqlConformance#allowExplicitRowValueConstructor'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services