You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 18:14:24 UTC
[GitHub] [airflow] cheelio opened a new pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
cheelio opened a new pull request #22510:
URL: https://github.com/apache/airflow/pull/22510
Currently, in the Apache Livy Hook, the `extra_headers` field (from the connection) is only passed to the post_batch request.
This makes certain functionality of the hook such as `poll_for_termination` not usable in combination with authentication proxy's such as Apache Knox. This PR adds the `extra_headers` field to all Livy requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22510:
URL: https://github.com/apache/airflow/pull/22510#issuecomment-1079972613
Static checks are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22510:
URL: https://github.com/apache/airflow/pull/22510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22510:
URL: https://github.com/apache/airflow/pull/22510#issuecomment-1077909728
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cheelio commented on pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
Posted by GitBox <gi...@apache.org>.
cheelio commented on pull request #22510:
URL: https://github.com/apache/airflow/pull/22510#issuecomment-1081086836
>
ah, sorry. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22510: Fix: Add extra headers to all livy API requests instead of only to post_batch
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22510:
URL: https://github.com/apache/airflow/pull/22510#issuecomment-1083542234
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org