You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:57:53 UTC
[GitHub] [iotdb] jt2594838 commented on a change in pull request #1866: fix some regression bugs
jt2594838 commented on a change in pull request #1866:
URL: https://github.com/apache/iotdb/pull/1866#discussion_r512370657
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -371,7 +374,12 @@ protected QueryDataSet processDataQuery(QueryPlan queryPlan, QueryContext contex
} else if (queryPlan instanceof LastQueryPlan) {
queryDataSet = queryRouter.lastQuery((LastQueryPlan) queryPlan, context);
} else {
- queryDataSet = queryRouter.rawDataQuery((RawDataQueryPlan) queryPlan, context);
+ try {
+ queryDataSet = queryRouter.rawDataQuery((RawDataQueryPlan) queryPlan, context);
+ } catch (IndexOutOfBoundsException e) {
Review comment:
I believe this is a misuse, since it does not involve any index, and I would prefer creating a new Exception like `IllegalTimeRangeException` of `IllegalPredicateException`. You may correct it within this PR or just create an issue about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org