You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jdye64 <gi...@git.apache.org> on 2016/04/22 19:29:02 UTC
[GitHub] nifi pull request: NIFI-1805
GitHub user jdye64 opened a pull request:
https://github.com/apache/nifi/pull/377
NIFI-1805
Expose BackPressureObjectThreshold and BackPressureDataSizeThreshold to
ConnectionStatus
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdye64/nifi NIFI-1805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 51505bd34f46ea55f0e807ab1d4e764977421aa6
Author: Jeremy Dyer <jd...@gmail.com>
Date: 2016-04-22T17:28:29Z
NIFI-1805
Expose BackPressureObjectThreshold and BackPressureDataSizeThreshold to
ConnectionStatus
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-213799213
I like the ReportingTask path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by jdye64 <gi...@git.apache.org>.
Github user jdye64 commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-213528810
It might make more sense to leave those sort of operations to a ReportingTask however? Does anyone have any thoughts around that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #377: NIFI-1805
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #377: NIFI-1805
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/377
@jdye64 Apologies for delays. These changes look fine and everything builds fine. As far as the other commentary on this thread, I will leave that to folks to generate other issues to track, but these changes should certainly help as a means for any of those enhancements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-215533199
We have talked before about having some sort of icon on a connection that indicates that back pressure is configured and then some sort of indicator that back pressure is applied. Perhaps an icon on the connection that is grey when configured but the threshold is not met, and then it would turn red or something if backpressure is actively being applied. The only issue with this approach is that we always have more & more things that we want to show and we have to balance what to show vs. how much screen real estate should be used. I am hoping that the UI redesign going on for 1.0 will make this work much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by aperepel <gi...@git.apache.org>.
Github user aperepel commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-213526177
I wonder if, upon crossing a threshold, we should raise a bulletin maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by aperepel <gi...@git.apache.org>.
Github user aperepel commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-215543265
@markap14 don't show more, change _how_ things are shown. in case of a connection and backpressure a simple gradient change in color (or a binary ok/throttled color) of the black is all it takes, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1805
Posted by jdye64 <gi...@git.apache.org>.
Github user jdye64 commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-213528547
@aperepel that isn't a bad idea. That takes a little more discussion around how often we continue to post that bulletin if the threshold is constantly exceeded, what severity, etc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---