You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by Svetlin Zarev <sv...@gmail.com> on 2017/08/02 12:54:12 UTC

Outdated/Junk PR

Hi,

I constantly get notifications about [1], which is now more than 1.5 years
old. It looks like some mistake - i.e to merge the 1.7.x into master.,
Github is regularly sending notifications to all watchers about it So what
do you think about discarding & closing it ?

[1] https://github.com/apache/tomee/pull/29

Kind regards,
Svetlin

Re: Outdated/Junk PR

Posted by Jonathan Gallimore <jo...@gmail.com>.

That worked! Thanks.

Jon

On Thu, Aug 3, 2017 at 12:12 PM, Jean-Louis Monteiro <
jlmonteiro@tomitribe.com> wrote:

>  You need to commit with a message to close it. You don't need additional
> permissions Jon
>
> Le 3 août 2017 12:08, "Jonathan Gallimore" <jo...@gmail.com>
> a
> écrit :
>
> > +1. Does anyone have permission to do that, or shall I raise a ticket
> with
> > infra?
> >
> > Jon
> >
> > On Wed, Aug 2, 2017 at 2:58 PM, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > > rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > >
> > > 2017-08-02 14:54 GMT+02:00 Svetlin Zarev <svetlin.angelov.zarev@gmail.
> > com
> > > >:
> > >
> > > > Hi,
> > > >
> > > > I constantly get notifications about [1], which is now more than 1.5
> > > years
> > > > old. It looks like some mistake - i.e to merge the 1.7.x into
> master.,
> > > > Github is regularly sending notifications to all watchers about it So
> > > what
> > > > do you think about discarding & closing it ?
> > > >
> > > > [1] https://github.com/apache/tomee/pull/29
> > > >
> > > > Kind regards,
> > > > Svetlin
> > > >
> > >
> >
>

Re: Outdated/Junk PR

Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.

 You need to commit with a message to close it. You don't need additional
permissions Jon

Le 3 août 2017 12:08, "Jonathan Gallimore" <jo...@gmail.com> a
écrit :

> +1. Does anyone have permission to do that, or shall I raise a ticket with
> infra?
>
> Jon
>
> On Wed, Aug 2, 2017 at 2:58 PM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > +1
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2017-08-02 14:54 GMT+02:00 Svetlin Zarev <svetlin.angelov.zarev@gmail.
> com
> > >:
> >
> > > Hi,
> > >
> > > I constantly get notifications about [1], which is now more than 1.5
> > years
> > > old. It looks like some mistake - i.e to merge the 1.7.x into master.,
> > > Github is regularly sending notifications to all watchers about it So
> > what
> > > do you think about discarding & closing it ?
> > >
> > > [1] https://github.com/apache/tomee/pull/29
> > >
> > > Kind regards,
> > > Svetlin
> > >
> >
>

Re: Outdated/Junk PR

Posted by Jonathan Gallimore <jo...@gmail.com>.

+1. Does anyone have permission to do that, or shall I raise a ticket with
infra?

Jon

On Wed, Aug 2, 2017 at 2:58 PM, Romain Manni-Bucau <rm...@gmail.com>
wrote:

> +1
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2017-08-02 14:54 GMT+02:00 Svetlin Zarev <svetlin.angelov.zarev@gmail.com
> >:
>
> > Hi,
> >
> > I constantly get notifications about [1], which is now more than 1.5
> years
> > old. It looks like some mistake - i.e to merge the 1.7.x into master.,
> > Github is regularly sending notifications to all watchers about it So
> what
> > do you think about discarding & closing it ?
> >
> > [1] https://github.com/apache/tomee/pull/29
> >
> > Kind regards,
> > Svetlin
> >
>

Re: Outdated/Junk PR

Posted by Romain Manni-Bucau <rm...@gmail.com>.

+1


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>

2017-08-02 14:54 GMT+02:00 Svetlin Zarev <sv...@gmail.com>:

> Hi,
>
> I constantly get notifications about [1], which is now more than 1.5 years
> old. It looks like some mistake - i.e to merge the 1.7.x into master.,
> Github is regularly sending notifications to all watchers about it So what
> do you think about discarding & closing it ?
>
> [1] https://github.com/apache/tomee/pull/29
>
> Kind regards,
> Svetlin
>