You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/18 07:41:21 UTC
[GitHub] [flink] JingGe opened a new pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
JingGe opened a new pull request #19145:
URL: https://github.com/apache/flink/pull/19145
## What is the purpose of the change
Found a potential visibility issue and some typos while reading the mailbox code.
The instance variable mainMailboxExecutor in StreamTask is package-private but only used in subclasses that are in the same package. The visibility should be protected.
## Brief change log
- change the instance variable mainMailboxExecutor in StreamTask to be protected
- fix the wrong local variable name in MailboxProcessor
- fix some typos in java doc
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1073997526",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c98d163d079876116ed7a37a2594da66f177efb6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073915816
> In Java, `protected` implies `package-private`, so it's strictly larger scope.
I see, thanks. It then makes sense to keep package-private which should be only changed if any subclass need to be in a different package. I will remove this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3bdaef38476ffd577838db549c0b38181f1dfd71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bdaef38476ffd577838db549c0b38181f1dfd71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bdaef38476ffd577838db549c0b38181f1dfd71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3bdaef38476ffd577838db549c0b38181f1dfd71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bdaef38476ffd577838db549c0b38181f1dfd71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bdaef38476ffd577838db549c0b38181f1dfd71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073997526
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073766951
I don't mind too much one way or another. I think it was package-private as it's more narrow scope compared to `protected`, and the smaller the scope, usually the better. But IMO it doesn't matter here too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1073997526",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1074182941",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c98d163d079876116ed7a37a2594da66f177efb6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
* c98d163d079876116ed7a37a2594da66f177efb6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072710472
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #19145:
URL: https://github.com/apache/flink/pull/19145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307)
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1073997526",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1074182941",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c98d163d079876116ed7a37a2594da66f177efb6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1074182941
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19145:
URL: https://github.com/apache/flink/pull/19145#discussion_r829875250
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -274,7 +274,7 @@
protected final MailboxProcessor mailboxProcessor;
- final MailboxExecutor mainMailboxExecutor;
+ protected final MailboxExecutor mainMailboxExecutor;
Review comment:
I can't verify if this is indeed correct, perhaps @fapaul of @AHeise can verify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19145:
URL: https://github.com/apache/flink/pull/19145#discussion_r829875250
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -274,7 +274,7 @@
protected final MailboxProcessor mailboxProcessor;
- final MailboxExecutor mainMailboxExecutor;
+ protected final MailboxExecutor mainMailboxExecutor;
Review comment:
I can't verify if this is indeed correct, perhaps @fapaul of @AHeise can verify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072200272
@MartijnVisser Would you like to review this PR? Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073915816
> > Yeah, I had the same thought. But after I checked the code, it is defined as package-private but used as protected. In this case, it even enlarge the visibility scope, because classes within this package but do not inherit `StreamTask` are able to access it.
>
> In Java, `protected` implies `package-private`, so it's strictly larger scope.
I see, thanks. It then makes sense to keep package-private which should be only changed if any subclass need to be in a different package. I will remove this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525",
"triggerID" : "1073997526",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
* c98d163d079876116ed7a37a2594da66f177efb6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073833418
> I don't mind too much one way or another. I think it was package-private as it's more narrow scope compared to `protected`, and the smaller the scope, usually the better. But IMO it doesn't matter here too much.
Yeah, I had the same thought. But after I checked the code, it is defined as package-private but used as protected. In this case, it even enlarge the visibility scope, because classes within this package but do not inherit `StreamTask` are able to access it. I guess it is not intended to work as package-private and is against OO design and might cause potential issue. Another issue is that any subclass of `StreamTask` that is not in the same package will not be able to access this instance variable. If we want to limit all subclasses of `StreamTask` be in the same package, we should control it via ArchUnit rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073671944
@pnowojski I guess the visibility change in the `StreamTask` is not a problem but can you double check that this was an oversight?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] rename local variable name and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
}, {
"hash" : "c98d163d079876116ed7a37a2594da66f177efb6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c98d163d079876116ed7a37a2594da66f177efb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
* c98d163d079876116ed7a37a2594da66f177efb6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072200272
@MartijnVisser Would you like to review this PR? Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307)
* f21c64d64e3b391f7259931f97799de607afae84 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072868814
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072111125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33307",
"triggerID" : "a7f56c1fc0170a575cd8eeb17e4dbbf87cc688b7",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "f21c64d64e3b391f7259931f97799de607afae84",
"triggerType" : "PUSH"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072710472",
"triggerType" : "MANUAL"
}, {
"hash" : "f21c64d64e3b391f7259931f97799de607afae84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319",
"triggerID" : "1072868814",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f21c64d64e3b391f7259931f97799de607afae84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1073891162
> Yeah, I had the same thought. But after I checked the code, it is defined as package-private but used as protected. In this case, it even enlarge the visibility scope, because classes within this package but do not inherit `StreamTask` are able to access it.
In Java, `protected` implies `package-private`, so it's strictly larger scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org