[GitHub] [spark] HyukjinKwon commented on a change in pull request #35415: [WIP][SPARK-37507][SQL] Add a new SQL function to_binary

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35415:
URL: https://github.com/apache/spark/pull/35415#discussion_r802304280



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2538,6 +2538,56 @@ case class Encode(value: Expression, charset: Expression)
     newLeft: Expression, newRight: Expression): Encode = copy(value = newLeft, charset = newRight)
 }
 
+/**
+ * Converts the input expression to a binary value based on the supplied format.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+  usage = """
+    _FUNC_(str[, fmt]) - Converts the input `str` to a binary value based on the supplied `fmt`.
+      By default, the binary format for conversion is "hex" if `fmt` is omitted.
+  """,
+  examples = """
+    Examples:
+      > SELECT _FUNC_('abc', 'utf-8');
+       abc
+  """,
+  since = "3.3.0",
+  group = "string_funcs")
+// scalastyle:on line.size.limit
+case class ToBinary(expr: Expression, format: Option[Expression], child: Expression)
+  extends RuntimeReplaceable {
+
+  def this(expr: Expression, format: Expression) = this(expr, Option(format),
+    format.toString match {
+      case "hex" => Unhex(expr)
+      case "utf-8" => Encode(expr, Literal("UTF-8"))
+      case "base64" => UnBase64(expr)
+      case "base2" => Cast(expr, BinaryType)
+    }
+  )

Review comment:
       We would have to do this like:
   
   ```scala
     def this(expr: Expression, format: Expression) = this(expr, Option(format),
       format match {
         case Literal("hex", StringType) => Unhex(expr)
         case Literal("utf-8", StringType) => Encode(expr, Literal("UTF-8"))
         case Literal("base64", StringType) => UnBase64(expr)
         case Literal("base2", StringType) => Cast(expr, BinaryType)
         case other => other
       }
     )
   ```
   
   So later this argument can be checked `checkInputDataTypes` instead of failing in the constructor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org