You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2013/12/03 16:53:15 UTC

svn commit: r1547445 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

Author: philip
Date: Tue Dec  3 15:53:15 2013
New Revision: 1547445

URL: http://svn.apache.org/r1547445
Log:
* subversion/libsvn_fs/fs-loader.c
  (svn_fs_lock): Disallow control characters in lock tokens.

Modified:
    subversion/trunk/subversion/libsvn_fs/fs-loader.c

Modified: subversion/trunk/subversion/libsvn_fs/fs-loader.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs/fs-loader.c?rev=1547445&r1=1547444&r2=1547445&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs/fs-loader.c (original)
+++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Tue Dec  3 15:53:15 2013
@@ -1527,10 +1527,10 @@ svn_fs_lock(svn_lock_t **lock, svn_fs_t 
                                  token, "opaquelocktoken");
 
       for (c = token; *c; c++)
-        if (! svn_ctype_isascii(*c))
+        if (! svn_ctype_isascii(*c) || svn_ctype_iscntrl(*c))
           return svn_error_createf(SVN_ERR_FS_BAD_LOCK_TOKEN, NULL,
-                                   _("Lock token '%s' is not ASCII "
-                                     "at byte %u"),
+                                   _("Lock token '%s' is not ASCII or is a "
+                                     "control character at byte %u"),
                                    token, (unsigned)(c - token));
 
       /* strlen(token) == c - token. */