You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/03 00:53:14 UTC

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #42: feat: add prometheus fetcher

wu-sheng commented on a change in pull request #42:
URL: https://github.com/apache/skywalking-satellite/pull/42#discussion_r644409566



##########
File path: protocol/gen-codes/skywalking/network/go.mod
##########
@@ -4,6 +4,4 @@ go 1.15
 
 replace google.golang.org/grpc => github.com/grpc/grpc-go v1.36.1
 
-replace google.golang.org/protobuf => github.com/golang/protobuf v1.4.3
-

Review comment:
       All these replacements seems strange. I am not sure why we remove this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org