[GitHub] [incubator-druid] himanshug edited a comment on issue #8366: improve Teamcity build speed

[GitBox <gi...@apache.org>]

himanshug edited a comment on issue #8366: improve Teamcity build speed
URL: https://github.com/apache/incubator-druid/issues/8366#issuecomment-524054194
 
 
   I asked because you proposed that it could be done with gradle plugin and I thought you would know whether it could be done on the current build :)
   
   anyways, thanks for the link to documentation. I read through it and discovered that most of the analysis info is stored in `.idea/inspectionProfiles/Druid.xml` which has lines like....
   
   
   ```
   $ fgrep "<inspection_tool" .idea/inspectionProfiles/Druid.xml | head
       <inspection_tool class="Annotator" enabled="true" level="WARNING" enabled_by_default="true" />
       <inspection_tool class="AntDuplicateTargetsInspection" enabled="true" level="WARNING" enabled_by_default="true" />
       <inspection_tool class="AntMissingPropertiesFileInspection" enabled="true" level="WARNING" enabled_by_default="true" />
       <inspection_tool class="AntResolveInspection" enabled="true" level="WARNING" enabled_by_default="true" />
       <inspection_tool class="ArrayEquality" enabled="true" level="ERROR" enabled_by_default="true" />
       <inspection_tool class="ArrayEquals" enabled="true" level="ERROR" enabled_by_default="true" />
       <inspection_tool class="ArrayHashCode" enabled="true" level="ERROR" enabled_by_default="true" />
       <inspection_tool class="ArrayObjectsEquals" enabled="true" level="ERROR" enabled_by_default="true" />
       <inspection_tool class="ArraysAsListWithZeroOrOneArgument" enabled="true" level="ERROR" enabled_by_default="true" />
       <inspection_tool class="AssertWithSideEffects" enabled="true" level="ERROR" enabled_by_default="true" />
   ```
   
   that suggests to me that teamcity build is applying these listed tools while analyzing the code and tagging the violations as WARNING/ERROR/... based on the "level" attribute in there.
   
   there are 142 of these inspection tools , 90 with level ERROR and 52 with rest.
   ```
   $ fgrep "<inspection_tool" .idea/inspectionProfiles/Druid.xml | wc -l
        142
   $ fgrep "<inspection_tool" .idea/inspectionProfiles/Druid.xml | grep 'level="ERROR"' | wc -l
         90
   $ fgrep "<inspection_tool" .idea/inspectionProfiles/Druid.xml | grep -v 'level="ERROR"' | wc -l
         52
   ```
   
   I am gonna do a quick PR that removes all `inspection_tool` tags that don't have level ERROR and that should probably make teamcity build only analyze for ERRORs and hopefully run significantly faster as well.
   Note: inspection tools could also be disabled/enabled from Intellij IDE UI (Editor -> Inspections)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org