[rocketmq-flink] 20/33: No need to call this function twice (#329)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duhengforever pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-flink.git

commit a04b0bf82e14b6400a311a49702fc72bc7fcd392
Author: 胖梁 <41...@qq.com>
AuthorDate: Fri Aug 23 09:37:31 2019 +0800

    No need to call this function twice (#329)
---
 src/main/java/org/apache/rocketmq/flink/RocketMQSink.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/rocketmq/flink/RocketMQSink.java b/src/main/java/org/apache/rocketmq/flink/RocketMQSink.java
index f3e200d..eecb72e 100644
--- a/src/main/java/org/apache/rocketmq/flink/RocketMQSink.java
+++ b/src/main/java/org/apache/rocketmq/flink/RocketMQSink.java
@@ -147,7 +147,7 @@ public class RocketMQSink<IN> extends RichSinkFunction<IN> implements Checkpoint
 
     private Message prepareMessage(IN input) {
         String topic = topicSelector.getTopic(input);
-        String tag = topicSelector.getTag(input) != null ? topicSelector.getTag(input) : "";
+        String tag = (tag = topicSelector.getTag(input)) != null ? tag : "";
 
         byte[] k = serializationSchema.serializeKey(input);
         String key = k != null ? new String(k, StandardCharsets.UTF_8) : "";