You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2012/11/19 15:29:00 UTC
[jira] [Created] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Hiram Chirino created PROTON-145:
------------------------------------
Summary: 256K Messages do not get transfered properly with a 64k pump size
Key: PROTON-145
URL: https://issues.apache.org/jira/browse/PROTON-145
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Hiram Chirino
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated PROTON-145:
---------------------------------
Attachment: PROTON-145-Test.patch
Test case to demonstrate the failure included in the attached PROTON-145-Test.patch
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500326#comment-13500326 ]
Rob Godfrey commented on PROTON-145:
------------------------------------
Are changes such as this actually necessary to make it work:
- while(endpoint != null && buffer.remaining() >= _maxFrameSize)
+ while(endpoint != null && buffer.remaining() > _maxFrameSize)
I would think that >= would be correct (you have *exactly* enough space for a frame) ... would be nervous about committing this change if this is required as it would seem to point at a larger issue.
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Fix.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated PROTON-145:
---------------------------------
Attachment: PROTON-145-Simplified.patch
Attaching PROTON-145-Simplified.patch. It backs out the change in PROTON-141 and adds better overflow protection.
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Fix.patch, PROTON-145-Simplified.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated PROTON-145:
---------------------------------
Attachment: PROTON-145-Fix.patch
Attaching PROTON-145-Fix.patch which contains a possible fix.
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Fix.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500365#comment-13500365 ]
Hiram Chirino commented on PROTON-145:
--------------------------------------
Yeah looks like the fix to PROTON-146 was the real fix to this problem.
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Fix.patch, PROTON-145-Simplified.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved PROTON-145.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.3
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Fix For: 0.3
>
> Attachments: PROTON-145-Fix.patch, PROTON-145-Simplified.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-145) 256K Messages do not get transfered
properly with a 64k pump size
Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500431#comment-13500431 ]
Rob Godfrey commented on PROTON-145:
------------------------------------
Simplified patch applied
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
> Key: PROTON-145
> URL: https://issues.apache.org/jira/browse/PROTON-145
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
> Attachments: PROTON-145-Fix.patch, PROTON-145-Simplified.patch, PROTON-145-Test.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira