You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/07/05 22:20:02 UTC

[jira] [Created] (HBASE-18324) [hbase-thirdparty] Tooling to prevent commits that mistakenly make use of unshaded protobuf/guava/etc.

stack created HBASE-18324:
-----------------------------

             Summary: [hbase-thirdparty] Tooling to prevent commits that mistakenly make use of unshaded protobuf/guava/etc.
                 Key: HBASE-18324
                 URL: https://issues.apache.org/jira/browse/HBASE-18324
             Project: HBase
          Issue Type: Bug
            Reporter: stack


Chatting w/ [~mdrob], he brought up the question of what if a dev makes use of unshaded protobuf or guava? Afterall, the old jars (pb2.5 and hadoops guava12.0 or whatever) are still on the CLASSPATH because upstream depends on them.

We could add a check as part of prebuild. It would complain if use of com.google instead of org.apache.hadoop.hbase.shaded.com.google. But even then, there are cases where com.google is legit (coprocessor endpoints) so it would have to let these pass.

TODO.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)