You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/01/15 21:57:59 UTC

[Bug 121627] New: [GTK] Scrollbars without steppers are buggy

https://issues.apache.org/ooo/show_bug.cgi?id=121627

            Bug ID: 121627
        Issue Type: DEFECT
           Summary: [GTK] Scrollbars without steppers are buggy
    Classification: Code
           Product: ui
           Version: AOO 3.4.1
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: cosimo.cecchi@gmail.com
                CC: issues@openoffice.apache.org

The default GNOME 3 theme for GTK removed the steppers from scrollbars.
Unfortunately this breaks the GTK theming layer of OpenOffice.org. See [1] for
details.
The summary is that this bug (and more bugs related to scrollbars) is fixed in
Libreoffice, which uses a fork of the same GTK theming layer code.

I didn't verify these patches on OpenOffice.org myself, but I believe these
should fix the issue [2] [3]. If you're backporting, it might be nice to also
backport these other two fixes from Libreoffice related to scrollbars.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=691434
[2]
http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=b38ee8c8d5bb10ade41d5ee4050ec4fda12fcbd2
[3]
http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=c2c8ac28a49fd26e01435e2c2714a7474c23f8a1
[4]
http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=092d72a5591283459eb261e26d57ad8ecf1d5280
[5]
http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=58d757fd295d48bcd2eef51c2f41f5014c1cda21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

4.1.1_release_blocker granted: [Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
jsc@apache.org has granted Andrea Pescetti <pe...@apache.org>'s request for
4.1.1_release_blocker:
Issue 121627: [GTK] Scrollbars without steppers are buggy
https://issues.apache.org/ooo/show_bug.cgi?id=121627


------- Additional Comments from jsc@apache.org
grant showstopper flag, the available fix can help to increase the usability on
Linux

I will take care of it

[Bug 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Cosimo Cecchi <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[GTK3] Scrollbars without   |[GTK] Scrollbars without
                   |steppers are buggy          |steppers are buggy

--- Comment #2 from Cosimo Cecchi <co...@gmail.com> ---
Ariel: thanks for the answer. I'll contact the original patch author and see if
this is an option.

Note that this is *not* related to GTK3, it happens with the GTK2 theming
layer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org
              Flags|4.1.1_release_blocker?      |4.1.1_release_blocker+

--- Comment #16 from jsc@apache.org ---
grant showstopper flag, the available fix can help to increase the usability on
Linux

I will take care of it

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #4 from Cosimo Cecchi <co...@gmail.com> ---
(In reply to comment #3)

> ha, sorry, I wanted to mark GNOME3, as this seems to be a Gnome3 only
> related bug: it's not reproducible on CentOS 5 with Gnome2 desktop, neither
> in KDE 4.9 with any of the widget styles, clearlooks, adwaite, etc
> (OpenOffice does not build any KDE3/4 vcl-plugin, so it is gtk2 application
> in KDE).

Yeah, it's likely that all the themes you tried use steppers on scrollbars.
Adwaita changed scrollbar style for GTK2 only recently (to match the GTK3
version of the theme) - you need at least the version shipped with GNOME 3.6 to
reproduce the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pescetti@apache.org

--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
*** Issue 124444 has been marked as a duplicate of this issue. ***

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #3 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #2)
> Note that this is *not* related to GTK3, it happens with the GTK2 theming
> layer.

ha, sorry, I wanted to mark GNOME3, as this seems to be a Gnome3 only related
bug: it's not reproducible on CentOS 5 with Gnome2 desktop, neither in KDE 4.9
with any of the widget styles, clearlooks, adwaite, etc (OpenOffice does not
build any KDE3/4 vcl-plugin, so it is gtk2 application in KDE).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #10 from Andre <aw...@googlemail.com> ---
Created attachment 83060
  --> https://issues.apache.org/ooo/attachment.cgi?id=83060&action=edit
Show scroll bars

This is an experimental patch that fixes the geometry calculations for scroll
bars.  It works on Ubuntu with Adwaita, Radiance and Ambience theme.  It also
works on Windows 7.  Did not check other platforms.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #20 from jsc@apache.org ---
patch integrated on AOO410 branch and trunk

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
          Component|ui                          |ui
             Latest|---                         |4.1-dev
    Confirmation on|                            |
            Version|AOO 3.4.1                   |OOo 3.3 or older
            Product|ui                          |General
     Ever confirmed|0                           |1

--- Comment #7 from Ariel Constenla-Haile <ar...@apache.org> ---
Confirmed in 3.3 and 3.4

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #11 from Andrea Pescetti <pe...@apache.org> ---
Thanks Andre, I confirm that the patch works for me on Fedora 19 with GNOME 3
and Adwaita.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

samalipraveena@yahoo.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
                 CC|                            |samalipraveena@yahoo.com.au

--- Comment #21 from samalipraveena@yahoo.com.au ---
Tested in Ubuntu 14.04 gnome shell version 3.10.4 theme adwaita. This bug is
verified fixed.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #19 from SVN Robot <sv...@dev.null.org> ---
"jsc" committed SVN revision 1604149 into trunk:
#121627# merge fix from aoo410 branch that fixes the geometry calculations
fo...

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 121627] [GTK3] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[GTK] Scrollbars without    |[GTK3] Scrollbars without
                   |steppers are buggy          |steppers are buggy
                 OS|All                         |Linux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #17 from SVN Robot <sv...@dev.null.org> ---
"jsc" committed SVN revision 1604121 into branches/AOO410:
#121627# integrate patch that fixes the geometry calculations for scroll bars

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #18 from Andrea Pescetti <pe...@apache.org> ---
Note that this hasn't been committed to trunk yet, as far as I can see, but
only to AOO410.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arielch@apache.org

--- Comment #1 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #0)
> I didn't verify these patches on OpenOffice.org myself, but I believe these
> should fix the issue [2] [3]. If you're backporting, it might be nice to
> also backport these other two fixes from Libreoffice related to scrollbars.

LO can (and actually does) take code from OpenOffice, but OpenOffice can't take
code from LO due to license conflict.

So, if the original developer isn't willing to contribute his patches to this
project, they cannot be included.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |4.1.1_release_blocker?

--- Comment #15 from Andrea Pescetti <pe...@apache.org> ---
Nominating for 4.1.1. Issue is very annoying for certain Linux users (depending
on desktop environment): cursor in scrollbars is invisible.

Patch available, works for me. Has duplicates in Bugzilla.

If approved for 4.1.1, it would be good to commit the patch early in the
proscess so that possible side-effects get caught early.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

jserock <js...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jserock@hotmail.com

--- Comment #12 from jserock <js...@hotmail.com> ---
Scrollbars are still not visible in AOO 4.1.0 RC4:

    AOO410m18(Build:9764)  -  Rev. 1589052
    2014-04-22 12:11 - Linux x86_64

I'm running 64-bit openSUSE 13.1 with Gnome 3.10.2 desktop.

Did the patch in Comment #10 make it into RC4?

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Hagar Delest <ha...@laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagar.delest@laposte.net

--- Comment #14 from Hagar Delest <ha...@laposte.net> ---
*** Issue 124788 has been marked as a duplicate of this issue. ***

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

4.1.1_release_blocker requested: [Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has asked  for 4.1.1_release_blocker:
Issue 121627: [GTK] Scrollbars without steppers are buggy
https://issues.apache.org/ooo/show_bug.cgi?id=121627


------- Additional Comments from Andrea Pescetti <pe...@apache.org>
Nominating for 4.1.1. Issue is very annoying for certain Linux users (depending
on desktop environment): cursor in scrollbars is invisible.

Patch available, works for me. Has duplicates in Bugzilla.

If approved for 4.1.1, it would be good to commit the patch early in the
proscess so that possible side-effects get caught early.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #8 from Andrea Pescetti <pe...@apache.org> ---
On the system where I noticed bug 124444 aka issue 124444 (duplicate of this
one) I strangely cannot reproduce the problem with 3.4.1. It's a very standard
Fedora 20 installation, with Gnome 3. I never saw the problem on any systems
with Gnome 2.

And, with the default configuration (I installed it with a clean dedicated user
profile only for this test) I see:
- Fedora 20, Gnome 3.10.2, Adwaita theme: 3.4.1 is OK, 4.0.0 has the bug
- Fedora 18, Gnome  3.6.3, Adwaita theme: 3.4.1 is OK, 4.0.0 has the bug

I'm surprised that 3.4.1 works correctly too, but it definitely does on these
two systems (see screenshot in the other issue). Both are 64-bit. In both cases
I used the official Italian versions. If any further detail is needed, just
ask. Leaving the version at 3.3 since clearly Ariel can reproduce with 3.3. and
3.4 too.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com

--- Comment #9 from Andre <aw...@googlemail.com> ---
The main problem could be related to wrong bounding boxes.  I looked at the
scroll bars of Writer and both scroll bars have bounding box that seem to cover
the whole edit view, only excluding the other scroll bar.  The rest of the
scroll bar seems to be painted in the center of that area and is probably
hidden by the edit view.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #13 from Andrea Pescetti <pe...@apache.org> ---
As explained by jsc on the dev list: the patch is experimental. It will not be
integrated in OpenOffice 4.1.0. I expect this to be committed to trunk soon
and, if it works well, to be integrated in 4.1.1 or in the next release.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.1

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Issue 121627] [GTK] Scrollbars without steppers are buggy

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121627

--- Comment #6 from Ariel Constenla-Haile <ar...@apache.org> ---
Created attachment 82917
  --> https://issues.apache.org/ooo/attachment.cgi?id=82917&action=edit
Already reproducible in 3.3 and 3.4

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.