You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Francesco Guardiani (Jira)" <ji...@apache.org> on 2021/10/13 16:17:00 UTC
[jira] [Comment Edited] (FLINK-24462) Refactor casting rules in a
similar fashion to DataStructureConverter
[ https://issues.apache.org/jira/browse/FLINK-24462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428285#comment-17428285 ]
Francesco Guardiani edited comment on FLINK-24462 at 10/13/21, 4:16 PM:
------------------------------------------------------------------------
A PoC of such new architecture is available here: https://github.com/apache/flink/compare/master...slinkydeveloper:FLINK-24462?diff-6f90ac7f239d7823eadd86a723beac0199a84de6a17b477e8f3580e2dbd746cbR48
I've also worked on a benchmark (code available here: https://github.com/apache/flink/commit/726cd79b814fed044005e2e972d73015a376a4da) testing the generated code performance with JMH. In particular, i'm testing upcasting from INT to BIGINT (which should be a performance sensitive cast). You find the results attached in this comment. [^results.txt]
[~twalthr] [~jark] [~matriv] [~airblader] do you have any opinions about this change?
was (Author: slinkydeveloper):
A PoC of such new architecture is available here: https://github.com/apache/flink/compare/master...slinkydeveloper:FLINK-24462?diff-6f90ac7f239d7823eadd86a723beac0199a84de6a17b477e8f3580e2dbd746cbR48
I've also worked on a benchmark (code available here: https://github.com/apache/flink/commit/726cd79b814fed044005e2e972d73015a376a4da) testing the generated code performance with JMH. In particular, i'm testing upcasting from INT to BIGINT (which should be a performance sensitive cast). You find the results attached in this comment. [^results.txt]
[~twalthr][~jark] do you have any opinions about this change?
> Refactor casting rules in a similar fashion to DataStructureConverter
> ---------------------------------------------------------------------
>
> Key: FLINK-24462
> URL: https://issues.apache.org/jira/browse/FLINK-24462
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: Francesco Guardiani
> Assignee: Francesco Guardiani
> Priority: Major
> Attachments: results.txt
>
>
> The goal of this issue is to reorganize CAST logic in rules, similarly to DataStructureConverter. This makes the casting rules easier to debug and extend, allows us to reuse some of the rules for https://issues.apache.org/jira/browse/FLINK-21456 without duplicating any code and simplifies/cleanups the code generator code base. These rules can be reused in the context of https://issues.apache.org/jira/browse/FLINK-24385 as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)