[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10533: IGNITE-18721 Disable WAL for index partition during full rebuild

["anton-vinogradov (via GitHub)" <gi...@apache.org>]

anton-vinogradov commented on code in PR #10533:
URL: https://github.com/apache/ignite/pull/10533#discussion_r1105952708


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java:
##########
@@ -1013,12 +1015,15 @@ private WalStateResult awaitCheckpoint(CheckpointProgress cpFut, WalStatePropose
      * Checks WAL disabled for cache group.
      *
      * @param grpId Group id.
+     * @param pageId Page id.
      * @return {@code True} if WAL disable for group. {@code False} If not.
      */
-    public boolean isDisabled(int grpId) {
+    public boolean isDisabled(int grpId, long pageId) {
         CacheGroupContext ctx = cctx.cache().cacheGroup(grpId);
 
-        return ctx != null && !ctx.walEnabled();
+        return ctx != null && (PageIdUtils.partId(pageId) == INDEX_PARTITION

Review Comment:
   Lets invert to cause calculation only when !ctx.indexWalEnabled()



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/aware/IndexBuildStatusStorage.java:
##########
@@ -109,8 +109,8 @@ public void stop() {
      * @param cacheCtx Cache context.
      * @see #onFinishRebuildIndexes
      */
-    public void onStartRebuildIndexes(GridCacheContext cacheCtx) {
-        onStartOperation(cacheCtx, true);
+    public void onStartRebuildIndexes(GridCacheContext cacheCtx, boolean fullRebuild) {

Review Comment:
   javadoc param specification missed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org