You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/14 16:42:41 UTC
[GitHub] [beam] Abacn opened a new pull request, #22273: Downgrade less informative logs during write to files
Abacn opened a new pull request, #22273:
URL: https://github.com/apache/beam/pull/22273
Related to #21269
Currently, Python WriteToFiles will generates 5 log entries for each destination, causing spams when there is lots of files. 4 of them are from detecting and logging orphan files. However, in the most cases there is no orphan files and these logs are marginally informative. This change downgrades them to debug level. With the recent change of log overrides options, users can still choose to check them by setting log overrides if they want to do so.
```
2022-06-13 16:18:48.980 EDT
Starting the file information of the input
2022-06-13 16:18:49.029 EDT
Finished listing 0 files in 0.04897665977478027 seconds.
2022-06-13 16:18:49.029 EDT
Some files may be left orphaned in the temporary folder: []
2022-06-13 16:18:49.029 EDT
Moving temporary file gs://***/temp/.temp723d02fd-e4e4-4d12-988c-1f86f57ff280/2656248552370679398_54267103-76e3-4e2a-bd02-b914bf547d8b to dir: gs://clouddfe-yihu-test/temp/ as 73-00000-of-00001test. Res: FileResult(file_name='gs://***/temp/.temp723d02fd-e4e4-4d12-988c-1f86f57ff280/2656248552370679398_54267103-76e3-4e2a-bd02-b914bf547d8b', shard_index=-1, total_shards=0, window=GlobalWindow, pane=None, destination='73')
2022-06-13 16:18:49.164 EDT
Checking orphaned temporary files for destination 73 and window GlobalWindow
```
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1194098091
R: @y1chi for final approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1184916927
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22273:
URL: https://github.com/apache/beam/pull/22273#discussion_r928917372
##########
sdks/python/apache_beam/io/aws/s3io.py:
##########
@@ -157,8 +157,9 @@ def list_prefix(self, path, with_metadata=False):
else:
break
- logging.info(
- "Finished listing %s files in %s seconds.",
+ logging.log(
+ # do not spam logs when list_prefix is likely used to check empty folder
+ logging.INFO if counter > 0 else logging.DEBUG,
Review Comment:
my bad. Fixing it, will double check changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1202409662
Reminder, please take a look at this pr: @y1chi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1202504409
R: @tvalentyn please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #22273:
URL: https://github.com/apache/beam/pull/22273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1184715547
# [Codecov](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22273](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c3ad56) into [master](https://codecov.io/gh/apache/beam/commit/139ca67317623fef1206f3f5da72292e636dd76f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (139ca67) will **decrease** coverage by `0.00%`.
> The diff coverage is `41.66%`.
```diff
@@ Coverage Diff @@
## master #22273 +/- ##
==========================================
- Coverage 74.25% 74.24% -0.01%
==========================================
Files 702 702
Lines 92961 93018 +57
==========================================
+ Hits 69028 69063 +35
- Misses 22666 22688 +22
Partials 1267 1267
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.62% <41.66%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.88% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `95.96% <33.33%> (-0.27%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/aws/s3io.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL3MzaW8ucHk=) | `84.42% <66.66%> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `92.26% <66.66%> (ø)` | |
| [sdks/python/apache\_beam/internal/dill\_pickler.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZGlsbF9waWNrbGVyLnB5) | `85.61% <0.00%> (-1.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.01% <0.00%> (-1.39%)` | :arrow_down: |
| [...ython/apache\_beam/io/gcp/bigquery\_read\_internal.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaW50ZXJuYWwucHk=) | `53.36% <0.00%> (-1.05%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.44% <0.00%> (-0.65%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.46% <0.00%> (-0.55%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.17% <0.00%> (-0.50%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/beam/pull/22273/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [139ca67...3c3ad56](https://codecov.io/gh/apache/beam/pull/22273?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #22273:
URL: https://github.com/apache/beam/pull/22273#discussion_r928069583
##########
sdks/python/apache_beam/io/aws/s3io.py:
##########
@@ -157,8 +157,9 @@ def list_prefix(self, path, with_metadata=False):
else:
break
- logging.info(
- "Finished listing %s files in %s seconds.",
+ logging.log(
+ # do not spam logs when list_prefix is likely used to check empty folder
+ logging.INFO if counter > 0 else logging.DEBUG,
Review Comment:
did you intentionally omit the `"Finished listing %s files in %s seconds.",` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22273: Downgrade less informative logs during write to files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22273:
URL: https://github.com/apache/beam/pull/22273#issuecomment-1202507153
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org