[GitHub] [bahir-flink] gyfora commented on a change in pull request #82: Add batch table env support and filter push down

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #82:
URL: https://github.com/apache/bahir-flink/pull/82#discussion_r438728912



##########
File path: flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/KuduTableFactory.java
##########
@@ -65,6 +65,7 @@
     public static final String KUDU_HASH_COLS = "kudu.hash-columns";
     public static final String KUDU_PRIMARY_KEY_COLS = "kudu.primary-key-columns";
     public static final String KUDU_REPLICAS = "kudu.replicas";
+    public static final String KUDU_IS_BOUNDED = "kudu.is-bounded";

Review comment:
       Why are we introducing the is-bounded flag? As far as I can tell this only affects the isBounded() method of the KuduTableSource and not the actual reading of the data.
   
   The Kudu reading logic at the moment reads the table contents at the start of the job so it is always bounded, I think we should not touch this logic now. 
   
   What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org