You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/25 13:32:30 UTC

[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12191: Fix sankey link value is 0, node will disappear

susiwen8 opened a new pull request #12191: Fix sankey link value is 0, node will disappear
URL: https://github.com/apache/incubator-echarts/pull/12191
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix link value is zero makes some nodes disappear. 
   
   
   
   ### Fixed issues
   
   Close #12189 
   
   ## Details
   
   ### Before: What was the problem?
   
   <img width="584" alt="Screen Shot 2020-02-25 at 21 30 19" src="https://user-images.githubusercontent.com/20318608/75251736-3500ef80-5816-11ea-9d9d-07b31c52f274.png">
   
   
   
   
   ### After: How is it fixed in this PR?
   <img width="541" alt="Screen Shot 2020-02-25 at 21 29 18" src="https://user-images.githubusercontent.com/20318608/75251779-45b16580-5816-11ea-8aed-ec6a41566e1c.png">
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12191: Fix sankey link value is 0, node will disappear

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12191: Fix sankey link value is 0, node will disappear
URL: https://github.com/apache/incubator-echarts/pull/12191#issuecomment-590868015
 
 
   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on issue #12191: Fix sankey link value is 0, node will disappear

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12191: Fix sankey link value is 0, node will disappear
URL: https://github.com/apache/incubator-echarts/pull/12191#issuecomment-590868477
 
 
   I'm trying to remove the line between `a` and `b1`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] catkinmu commented on issue #12191: Fix sankey link value is 0, node will disappear

Posted by GitBox <gi...@apache.org>.
catkinmu commented on issue #12191: Fix sankey link value is 0, node will disappear
URL: https://github.com/apache/incubator-echarts/pull/12191#issuecomment-602007043
 
 
    can I use  npm update echarts -S  ？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org