[jira] [Comment Edited] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637853#comment-15637853 ] 

Leif Hedstrom edited comment on TS-1257 at 11/4/16 10:05 PM:
-------------------------------------------------------------

My main concern is that this goes against what we have said we want to do. That's how we ended up in the mess that is IpAllow, where it's using STL containers for absolutely no good reason whatsoever. It's easier to consistently say no to STL on the critical path, than making exceptions.


was (Author: zwoop):
My main concern is that goes against what we have said we want to do. That's how we ended up in the mess that is IpAllow, where it's using STL containers for absolutely no good reason whatsoever. It's easier to consistently say no to STL on the critical path, than making exceptions.

> Replace Tcl_Hash* with lib/ts/Map
> ---------------------------------
>
>                 Key: TS-1257
>                 URL: https://issues.apache.org/jira/browse/TS-1257
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cleanup, Core
>            Reporter: Igor Galić
>            Assignee: Syeda Persia Aziz
>             Fix For: 7.1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have already discussed looking into removing the old Tcl cruft by replacing it with {{Map}}, but have neither followed up on the ML nor Jira - or in the code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly to all developers, replace {{InkHashTable}} with {{Map}}, remains to be discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)