You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2024/06/05 00:23:08 UTC

[PR] fix(explore): Drill to detail truncates int64 IDs [superset]

justinpark opened a new pull request, #29081:
URL: https://github.com/apache/superset/pull/29081

   ### SUMMARY
   This commit fixes the missing `json-bigint` parseMethod on dril-to-detail view request.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   ![Screenshot 2024-06-04 at 5 18 24 PM](https://github.com/apache/superset/assets/1392866/02632d15-734c-4725-95fe-17f1eb19621c)
   
   After:
   
   ![Screenshot 2024-06-04 at 5 18 00 PM](https://github.com/apache/superset/assets/1392866/883564f1-e8d8-479d-a90d-d346528a201f)
   
   
   ### TESTING INSTRUCTIONS
   Create a chart including int64 value and then click "drill to detail" in the dashboard
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(explore): Drill to detail truncates int64 IDs [superset]

Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #29081:
URL: https://github.com/apache/superset/pull/29081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org