You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by apiri <gi...@git.apache.org> on 2016/02/14 01:02:43 UTC
[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/220
NIFI-1511 Incorporate Groovy unit tests as part of the build instead of via profile
Incorporating Groovy unit tests as part of the main build and providing explicit compile scope on the Groovy dependency for the scripting bundle.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi NIFI-1511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #220
----
commit efad9b6b81f0ee95fc49905be79d0a65dd0a0c8a
Author: Aldrin Piri <al...@apache.org>
Date: 2016-02-14T00:00:05Z
NIFI-1511 Incorporating Groovy unit tests as part of the main build and providing explicit compile scope on the Groovy dependency for the scripting bundle.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/220#issuecomment-189308095
Reviewing for +1 and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/220#issuecomment-188922521
Ran the tests, verified the Groovy JAR was available to the scripting NAR and that the Groovy unit tests ran successfully.
LGTM, needs +1/merge from committer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---