You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/30 08:14:57 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18627: Add default weight rule configuration option

ephraimbuddy commented on a change in pull request #18627:
URL: https://github.com/apache/airflow/pull/18627#discussion_r719167263



##########
File path: airflow/models/baseoperator.py
##########
@@ -497,7 +497,7 @@ def __init__(
         params: Optional[Dict] = None,
         default_args: Optional[Dict] = None,
         priority_weight: int = 1,
-        weight_rule: str = WeightRule.DOWNSTREAM,
+        weight_rule: str = conf.get('core', 'default_task_weight_rule'),

Review comment:
       ```suggestion
           weight_rule: str = conf.get('core', 'default_task_weight_rule', fallback=WeightRule.DOWNSTREAM),
   ```
   Should we have a fallback too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org