You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/14 18:04:46 UTC
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6391
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
[DOCS] Genericize admission_config_noncm page
A couple of fleeting / invisible references to 'cm'.
Take 'em out to avoid false positives in our grep reports.
Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
---
M docs/topics/impala_admission.xml
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/6391/1
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
Patch Set 1:
I looked at the source and the comma is outside the <q> tag. It's not super critical, but an English wog like me noticed it. :-)
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6391/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
PS1, Line 38: .
> Period should be placed within the double quotation marks for American Engl
The purpose of the <q> tag is to enclose only the text in question. The transform can then decide whether to move any punctuation inside the quotation marks in the output. (It may not actually be implemented in the DITA-OT transform, but that's the way it has traditionally worked.)
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/100/
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
[DOCS] Genericize admission_config_noncm page
A couple of fleeting / invisible references to 'cm'.
Take 'em out to avoid false positives in our grep reports.
Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Reviewed-on: http://gerrit.cloudera.org:8080/6391
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_admission.xml
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Genericize admission_config_noncm page
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Files build cleanly, displays as expected in html & pdf, and source XML is clean. Only one small foobar where the comman should be placed within the quotations marks, but marking this +1.
http://gerrit.cloudera.org:8080/#/c/6391/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
PS1, Line 38: .
Period should be placed within the double quotation marks for American English.
--
To view, visit http://gerrit.cloudera.org:8080/6391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes