You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/14 21:49:10 UTC
Review Request 16868: Fix build break caused by a584410.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/
-----------------------------------------------------------
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
Fix build break caused by a584410.
Diffs
-----
src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
Diff: https://reviews.apache.org/r/16868/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/#review31797
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 14, 2014, 12:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16868/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 12:53 p.m.)
>
>
> Review request for Aurora, Jake Farrell and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix build break caused by a584410.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
> src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
>
> Diff: https://reviews.apache.org/r/16868/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> I have a failure on test_ephemerals:
> src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
>
> Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/#review31805
-----------------------------------------------------------
Ship it!
Ship It!
- Jake Farrell
On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16868/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:53 p.m.)
>
>
> Review request for Aurora, Jake Farrell and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix build break caused by a584410.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
> src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
>
> Diff: https://reviews.apache.org/r/16868/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> I have a failure on test_ephemerals:
> src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
>
> Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 14, 2014, 9:10 p.m., Jake Farrell wrote:
> > Uploaded an updated diff which is passing all tests for me locally with no issues
>
> Bill Farner wrote:
> Did you try my diff to see if it was green for you?
Follow-up from IRC chat. Jake had success with my original patch, proceeding with that and will investigate test_ephemerals issue offline.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/#review31794
-----------------------------------------------------------
On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16868/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:53 p.m.)
>
>
> Review request for Aurora, Jake Farrell and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix build break caused by a584410.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
> src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
>
> Diff: https://reviews.apache.org/r/16868/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> I have a failure on test_ephemerals:
> src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
>
> Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 14, 2014, 9:10 p.m., Jake Farrell wrote:
> > Uploaded an updated diff which is passing all tests for me locally with no issues
Did you try my diff to see if it was green for you?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/#review31794
-----------------------------------------------------------
On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16868/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:53 p.m.)
>
>
> Review request for Aurora, Jake Farrell and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix build break caused by a584410.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
> src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
>
> Diff: https://reviews.apache.org/r/16868/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> I have a failure on test_ephemerals:
> src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
>
> Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/#review31794
-----------------------------------------------------------
Uploaded an updated diff which is passing all tests for me locally with no issues
- Jake Farrell
On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16868/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:53 p.m.)
>
>
> Review request for Aurora, Jake Farrell and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix build break caused by a584410.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
> src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
>
> Diff: https://reviews.apache.org/r/16868/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> I have a failure on test_ephemerals:
> src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
>
> Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16868: Fix build break caused by a584410.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16868/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 8:53 p.m.)
Review request for Aurora, Jake Farrell and Kevin Sweeney.
Repository: aurora
Description
-------
Fix build break caused by a584410.
Diffs
-----
src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9
src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665
Diff: https://reviews.apache.org/r/16868/diff/
Testing (updated)
-------
./pants src/test/python:all
I have a failure on test_ephemerals:
src.test.python.apache.thermos.core.test_ephemerals ..... FAILURE
Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others).
Thanks,
Bill Farner