You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/08 22:02:15 UTC
[GitHub] [maven-gh-actions-shared] Tibor17 opened a new pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Tibor17 opened a new pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29
Added `timeout-minutes`, `ff-timeout-minutes` and `max-parallel`.
This can be an update in V2 a new V3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a change in pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#discussion_r780713257
##########
File path: .github/workflows/maven-verify.yml
##########
@@ -170,6 +189,7 @@ jobs:
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
+ max-parallel: ${{ inputs.max-parallel }}
Review comment:
Please fix indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] Tibor17 commented on a change in pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#discussion_r780718048
##########
File path: .github/workflows/maven-verify.yml
##########
@@ -170,6 +189,7 @@ jobs:
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
+ max-parallel: ${{ inputs.max-parallel }}
Review comment:
But the indent is right, the problem is that GH shows you only 3 lines above, these three lines are nested ones. It looks like this:
```
strategy:
fail-fast: ${{ inputs.verify-fail-fast }}
matrix:
os: ${{ fromJSON( inputs.os-matrix ) }}
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
**max-parallel: ${{ inputs.max-parallel }}**
steps:
- name: Should run
id: should-run
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] Tibor17 merged pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] Tibor17 commented on a change in pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#discussion_r780718048
##########
File path: .github/workflows/maven-verify.yml
##########
@@ -170,6 +189,7 @@ jobs:
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
+ max-parallel: ${{ inputs.max-parallel }}
Review comment:
But the indent is right, the problem is that GH shows you only 3 lines above, these three lines are nested ones. It looks like this:
```
strategy:
fail-fast: ${{ inputs.verify-fail-fast }}
matrix:
os: ${{ fromJSON( inputs.os-matrix ) }}
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
max-parallel: ${{ inputs.max-parallel }}
steps:
- name: Should run
id: should-run
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] Tibor17 commented on pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#issuecomment-1008161912
@slawekjaranowski
Would you pls check this? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a change in pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#discussion_r780748554
##########
File path: .github/workflows/maven-verify.yml
##########
@@ -170,6 +189,7 @@ jobs:
jdk: ${{ fromJSON( inputs.jdk-matrix ) }}
distribution: ${{ fromJSON( inputs.jdk-distribution-matrix ) }}
exclude: ${{ fromJSON( inputs.matrix-exclude ) }}
+ max-parallel: ${{ inputs.max-parallel }}
Review comment:
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] Tibor17 commented on pull request #29: timeout-minutes, ff-timeout-minutes and max-parallel
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #29:
URL: https://github.com/apache/maven-gh-actions-shared/pull/29#issuecomment-1014912026
@slawekjaranowski
Thx, so i will push it to the `v2` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org