You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/03/17 00:41:44 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new issue, #492: Replace glob package
Shanedell opened a new issue, #492:
URL: https://github.com/apache/daffodil-vscode/issues/492
The `glob` package has a lot of dependencies and isn't used to often. Also in later version I believe it throws some unexpected errors. I think we can get rid of this package and use vanilla TypeScript code with recursion to replace it.
Places that currently use glob
```txt
build/scripts/package.ts
src/tests/suite/index.ts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Replace glob package [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #492:
URL: https://github.com/apache/daffodil-vscode/issues/492#issuecomment-1863121486
I am going to close this issue as I don't think it needs to be done. Also, documentation found at [Testing VSCode Extension](https://code.visualstudio.com/api/working-with-extensions/testing-extension#the-test-runner-script), setups up running the tests using glob so trying to remove it may cause issues trying to run tests. But this package is also a dev dependency so it never gets published into our extension and I can't completely what the issues were that I ran into before. But again I don't think we need to this unless we start running into issues causes strictly by having the glob package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Replace glob package [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell closed issue #492: Replace glob package
URL: https://github.com/apache/daffodil-vscode/issues/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Replace glob package [daffodil-vscode]
Posted by "nlewis05 (via GitHub)" <gi...@apache.org>.
nlewis05 commented on issue #492:
URL: https://github.com/apache/daffodil-vscode/issues/492#issuecomment-1850959869
> am not sure how much this is needed. After looking over some things, glob seems to only be used by us for some scripting stuff. So it shouldn't be getting packaged in our releases.
Would it be possible to document those unexpected errors in this ticket? If they seem to be specific to this package, then we can close the issue with those errors documented, and if they are because of something else within the extension, then at least we have that documented somewhere and investigate further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Replace glob package [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #492:
URL: https://github.com/apache/daffodil-vscode/issues/492#issuecomment-1804797901
I am not sure how much this is needed. After looking over some things, glob seems to only be used by us for some scripting stuff. So it shouldn't be getting packaged in our releases.
@scholarsmate @mbeckerle @stevedlawrence @arosien @nlewis05 @stricklandrbls @NolanMatt @NolanMatt @michael-hoke @rthomas320 What does everyone think, should this still be done for 1.4.0 or is it non necessary to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org