You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/30 08:02:57 UTC
[GitHub] [inlong] ciscozhou opened a new pull request, #5287: [INLONG-5285][Manager] Support custom query for group, stream, source and sink
ciscozhou opened a new pull request, #5287:
URL: https://github.com/apache/inlong/pull/5287
### Prepare a Pull Request
- Title Example: [INLONG-5285][Manager] Support custom query for group, stream, source and sink
- Fixes #5285
### Motivation
*Support custom query for group, stream, source and sink*
### Modifications
*When querying group, stream, source or sink, it should support custom query by field.*
### Verifying this change
- [ ] This change is a trivial rework/code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5287: [INLONG-5285][Manager] Support custom query for group, stream, source and sink
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5287:
URL: https://github.com/apache/inlong/pull/5287#discussion_r933821027
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/OrderFieldEnum.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.enums;
+
+import org.apache.inlong.manager.common.beans.PageRequest;
+
+/**
+ * The order field enumeration.
+ */
+public enum OrderFieldEnum {
+
+ CREATE_TIME,
+
+ MODIFY_TIME;
Review Comment:
OK, in order to avoid the risk of SQL injection, it is necessary to verify the parameters passed in by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5287: [INLONG-5285][Manager] Support custom query for group, stream, source and sink
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5287:
URL: https://github.com/apache/inlong/pull/5287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5287: [INLONG-5285][Manager] Support custom query for group, stream, source and sink
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5287:
URL: https://github.com/apache/inlong/pull/5287#discussion_r933773347
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/OrderFieldEnum.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.enums;
+
+import org.apache.inlong.manager.common.beans.PageRequest;
+
+/**
+ * The order field enumeration.
+ */
+public enum OrderFieldEnum {
+
+ CREATE_TIME,
+
+ MODIFY_TIME;
Review Comment:
Should support other fields to order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org