[jira] [Commented] (SOLR-12313) Removing TestInjection#waitForInSyncWithLeader

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786654#comment-16786654 ] 

ASF subversion and git services commented on SOLR-12313:
--------------------------------------------------------

Commit 4eb1c6f3c672b301999c9ee9e3cfcc954e213b1b in lucene-solr's branch refs/heads/master from Cao Manh Dat
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4eb1c6f3c ]

SOLR-12313: Removing TestInjection#waitForInSyncWithLeader


> Removing TestInjection#waitForInSyncWithLeader
> ----------------------------------------------
>
>                 Key: SOLR-12313
>                 URL: https://issues.apache.org/jira/browse/SOLR-12313
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Priority: Major
>
> This really should have some doc for why it would be used.
> I also think it causes BasicDistributedZkTest to take forever for sometimes and perhaps other tests?
> I think checking for uncommitted data is probably a race condition and should be removed.
> Checking index versions should follow the rules that replication does - if the slave is higher than the leader, it's in sync, being equal is not required. If it's expected for a test it should be a specific test that fails. This just introduces massive delays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org