You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Uwe L. Korn (JIRA)" <ji...@apache.org> on 2017/02/23 08:23:44 UTC

[jira] [Resolved] (PARQUET-892) [C++] Clean up link library targets in CMake files

     [ https://issues.apache.org/jira/browse/PARQUET-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe L. Korn resolved PARQUET-892.
---------------------------------
       Resolution: Fixed
    Fix Version/s: cpp-1.0.0

Issue resolved by pull request 259
[https://github.com/apache/parquet-cpp/pull/259]

> [C++] Clean up link library targets in CMake files
> --------------------------------------------------
>
>                 Key: PARQUET-892
>                 URL: https://issues.apache.org/jira/browse/PARQUET-892
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>             Fix For: cpp-1.0.0
>
>
> See mailing list discussion today. 
> In 
> https://github.com/apache/parquet-cpp/blob/master/CMakeLists.txt#L623
> the dependencies are being passed with {{LINK_PRIVATE}} to parquet_static -- because static libs do not bundle their dependencies, I believe that the link libraries need to be passed to LINK_PUBLIC. I will put up a patch and see if that resolves the issue that the contributor is facing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)