[GitHub] [fineract] galovics commented on a diff in pull request #2590: FINERACT-1741: Introduce Lombok to creditbureau module

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2590:
URL: https://github.com/apache/fineract/pull/2590#discussion_r969647955


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
 import javax.persistence.ManyToOne;
 import javax.persistence.OneToOne;
 import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
 
 @SuppressWarnings({ "MemberName" })
 @Entity
 @Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
 public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
 
-    @Column(name = "is_credit_check_mandatory")
-    private boolean isCreditCheckMandatory;
+    @Column(name = "credit_check_mandatory")
+    private boolean creditCheckMandatory;
 
     @Column(name = "skip_credit_check_in_failure")
     private boolean skipCreditCheckInFailure;
 
     @Column(name = "stale_period")
     private int stalePeriod;
 
-    @Column(name = "is_active")
-    private boolean isActive;
+    @Column(name = "active")

Review Comment:
   Missing the liquibase script for this change.



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
 import javax.persistence.ManyToOne;
 import javax.persistence.OneToOne;
 import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
 
 @SuppressWarnings({ "MemberName" })
 @Entity
 @Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
 public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
 
-    @Column(name = "is_credit_check_mandatory")
-    private boolean isCreditCheckMandatory;
+    @Column(name = "credit_check_mandatory")

Review Comment:
   Missing the liquibase script for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org