You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Kasper Sørensen <i....@gmail.com> on 2014/07/19 21:40:53 UTC
Some improvements for review - please let me push :-)
Hi all,
I've submitted two issues for review:
https://reviews.apache.org/r/23711
This one's about deserializing ColumnTypes of the old enum type into the
new interface. We need this at Human Inference because we have old
serialized objects that we need to be able to recreate. This is kinda high
prio for me, although I can imagine that for everyone else it's like "who
cares?" :-)
https://reviews.apache.org/r/23712
I recently have been starting moving some upstream projects from JDK6 to
JDK7 ... So I started building MM with JDK7 and found a few stupidities
that needed updating so that we do not rely on JDK-specific implementation
details.
Both things are IMO quite risk-free improvements, but of course I wanted to
let people give their feedback. Would anyone object to these improvements?
Would deerly appreciate anyone giving their feedback or their +1.
Best regards,
Kasper
Re: Some improvements for review - please let me push :-)
Posted by Kasper Sørensen <i....@gmail.com>.
Great, I'll proceed with the push :-)
2014-07-19 23:34 GMT+02:00 Ankit Kumar <ak...@gmail.com>:
> +1
>
> ~Ankit
>
> > On 19 Jul 2014, at 21:40, Kasper Sørensen <
> i.am.kasper.sorensen@gmail.com> wrote:
> >
> > Hi all,
> >
> > I've submitted two issues for review:
> >
> > https://reviews.apache.org/r/23711
> > This one's about deserializing ColumnTypes of the old enum type into the
> > new interface. We need this at Human Inference because we have old
> > serialized objects that we need to be able to recreate. This is kinda
> high
> > prio for me, although I can imagine that for everyone else it's like "who
> > cares?" :-)
> >
> > https://reviews.apache.org/r/23712
> > I recently have been starting moving some upstream projects from JDK6 to
> > JDK7 ... So I started building MM with JDK7 and found a few stupidities
> > that needed updating so that we do not rely on JDK-specific
> implementation
> > details.
> >
> > Both things are IMO quite risk-free improvements, but of course I wanted
> to
> > let people give their feedback. Would anyone object to these
> improvements?
> > Would deerly appreciate anyone giving their feedback or their +1.
> >
> > Best regards,
> > Kasper
>
Re: Some improvements for review - please let me push :-)
Posted by Ankit Kumar <ak...@gmail.com>.
+1
~Ankit
> On 19 Jul 2014, at 21:40, Kasper Sørensen <i....@gmail.com> wrote:
>
> Hi all,
>
> I've submitted two issues for review:
>
> https://reviews.apache.org/r/23711
> This one's about deserializing ColumnTypes of the old enum type into the
> new interface. We need this at Human Inference because we have old
> serialized objects that we need to be able to recreate. This is kinda high
> prio for me, although I can imagine that for everyone else it's like "who
> cares?" :-)
>
> https://reviews.apache.org/r/23712
> I recently have been starting moving some upstream projects from JDK6 to
> JDK7 ... So I started building MM with JDK7 and found a few stupidities
> that needed updating so that we do not rely on JDK-specific implementation
> details.
>
> Both things are IMO quite risk-free improvements, but of course I wanted to
> let people give their feedback. Would anyone object to these improvements?
> Would deerly appreciate anyone giving their feedback or their +1.
>
> Best regards,
> Kasper